chore: update cockroachdb init-db example #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved certificate patching out of kustomization.yaml
MarcinGinszt
approved these changes
Aug 1, 2024
|
The diff shows a change: is this expected? |
Good spot |
matthewhughes-uw
approved these changes
Aug 1, 2024
| @@ -14,3 +14,11 @@ spec: | |||
| # name of the user that the init job will grant access on the DB to | |||
| - name: DB_USER | |||
| value: "example_user" | |||
| --- | |||
| apiVersion: cert-manager.io/v1 | |||
There was a problem hiding this comment.
is this strictly part of the init process, or more general? I'm wondering if it would be clearer if this were in its own file like cert.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved certificate patching out of kustomization.yaml