feat(opencl): add optional OpenCL backend support via Cargo feature #833
+25
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey mate,
Simple yet high value add, I thought I should upstream it. I have tested this on Linux and Android. The OpenCL backend is much more reliable than Vulkan.
✨ Summary
opencl
feature for both crates, package ggml-opencl sources, and enable GGML_OPENCL in build.rs with per-OS linking to the OpenCL loader. Keeps changes consistent with existing CUDA/Vulkan patterns.🔎 Diagnosis
🚀 Changes
llama-cpp-2/Cargo.toml
and added new globbing tollama-cpp-sys-2/Cargo.toml
README.md
should help SEO if that matters anymorellama-cpp-2-sys/build.rs
- matched the existing patterns☁️ What you’ll need to do
opencl
feature flag🧪 Smoke test
✅ Acceptance
build.rs
are correct.