Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghcup: support vanilla and cross compilers #126

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

Erchiusx
Copy link
Contributor

Checklist

  • 更新 README

ghcup metadata 在 0.0.7 添加了 vanilla ,
并在 0.0.8 添加了 cross compiler ,
而在原本的 version parser 中并没有支持。

我修改了 parseVersionFromFileName 以添加支持,
同时考虑到未来可能的更多不同 metadata 版本,
实现了向前兼容(但性能更差的) parser 版本。

ghcup metadata 在 0.0.7 添加了 vanilla ,
并在 0.0.8 添加了 cross compiler ,
而在原本的 version parser 中并没有支持。

我修改了 parseVersionFromFileName 以添加支持,
同时考虑到未来可能的更多不同 metadata 版本,
实现了向前兼容(但性能更差的) parser 版本。
ghcup/ghcupsync.hs Outdated Show resolved Hide resolved
@Erchiusx
Copy link
Contributor Author

此外我还要寻求一个建议:
是否要启用注释中写的“可能前向兼容”版本,还是仅针对当前的需要继续使用 <|> parser?

@taoky
Copy link
Member

taoky commented Dec 25, 2024

此外我还要寻求一个建议: 是否要启用注释中写的“可能前向兼容”版本,还是仅针对当前的需要继续使用 <|> parser?

先保持现在这样吧,如果未来有更多的这种版本的话再说。

@taoky taoky merged commit cf2948d into ustclug:master Dec 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants