Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winget-source: rename index file after syncing is done #113

Merged
merged 2 commits into from
Jul 1, 2024
Merged

winget-source: rename index file after syncing is done #113

merged 2 commits into from
Jul 1, 2024

Conversation

taoky
Copy link
Member

@taoky taoky commented Jun 30, 2024

Try fixing the issue mentioned in ustclug/discussions#435 (comment).

cc @stevapple

@taoky taoky force-pushed the winget-move-manifest-after-sync branch from 196ab87 to 5590d89 Compare June 30, 2024 18:13
@taoky taoky force-pushed the winget-move-manifest-after-sync branch from 5590d89 to 2fbf158 Compare June 30, 2024 18:32
@stevapple
Copy link
Contributor

Given that .bak is usually an older copy (backup), maybe we can use .source.msix instead?

@taoky
Copy link
Member Author

taoky commented Jul 1, 2024

Given that .bak is usually an older copy (backup), maybe we can use .source.msix instead?

It's much simpler to add .bak at the end of uri than prepending . in the stem of path.

@stevapple
Copy link
Contributor

I'm worrying about the confusion caused by the convention of .bak files and what this file actually is.

Any alternatives, perhaps .tmp?

stevapple
stevapple approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@stevapple stevapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a quick fix, hopefully it should solve the problem

@taoky taoky merged commit 2e548e5 into master Jul 1, 2024
1 check passed
@taoky taoky deleted the winget-move-manifest-after-sync branch July 1, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevapple stevapple stevapple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taoky @stevapple