Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations v1 #1505

Open
wants to merge 29 commits into
base: development
Choose a base branch
from
Open

Translations v1 #1505

wants to merge 29 commits into from

Conversation

Angamanga
Copy link
Contributor

@Angamanga Angamanga commented Dec 16, 2024

This PR adds the translations-feature to posts.
To test:
Add a new translation:

  • As a logged in user with edit-rights...
  • Go to data-view and click on a post
  • Click on the translate-icon (the icon is currently only available in the detailed-view. We can discuss if it should be in feed-view/map-view as well when planning for V2)
  • Translations-modal opens
  • There is a list of languages to choose between
    - [ ] The original-language for a post is displayed first in the list and is disabled (Waiting for backend-fix for this so not working yet)
  • Click on a language
  • An edit-view opens
  • Add translations and save
  • The window closes and the post is displayed in the translated language
  • Click on Change language and add a new translation from the modal
  • The new language is displayed
  • Click on "View original"
  • The original is displayed
    View a translation
  • As a logged out user, click on a published post that has translations
  • Select a language in the dropdown
  • The window closes and the post is displayed in the translated language

Above should also work on small screens
I haven't covered all cases of closing and opening the modal but test around and see how it behaves...

Copy link

linear bot commented Dec 16, 2024

@Angamanga Angamanga marked this pull request as ready for review December 18, 2024 10:05
@Angamanga Angamanga requested a review from ushahidlee December 18, 2024 10:07
Copy link
Contributor

@ushahidlee ushahidlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and the functionality is 🔥

@Angamanga
Copy link
Contributor Author

Note: Waiting with merging until it is possible to save base_language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants