Translations v1 #1505
Merged
Translations v1 #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushahidlee
approved these changes
Dec 18, 2024
|
Note: Waiting with merging until it is possible to save base_language. |
tuxpiper
pushed a commit
that referenced
this pull request
Feb 13, 2025
* Adding translations-button to post-head * Adding post-translations component * Fix language-length check * Translations component for posts * Moving permissions-check * Sending base-language when saving a post * Displaying existing post-translations in the translation-edit view * Saving translations properly * Displaying translations in post-details * Fixing error when saving translations * New alert for success/info * Info/alert-box in posts when showing a translated post * Displaying post in translated language after saving post * Displaying survey-questions in selected language if available * Hiding translation-icon in list * Preserving translations when editing a post * Using full language-list for post-translations * Adding validation+small style-fixes * CSS-cleanup for post-translations * Moving strings to en.json * Removing console.log * Using site-language if no base_language is set * Hiding translations-icon everywhere except in details * Adding strings to en.json * Displaying translation-info in post-modal * Using full language-list for translations * Only displaying icon if translations are available (for non-edit-users) * Remove line under dropdown but keep spacing * Displaying original language for the post
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the translations-feature to posts.
To test:
Add a new translation:
- [ ] The original-language for a post is displayed first in the list and is disabled (Waiting for backend-fix for this so not working yet)
View a translation
Above should also work on small screens
I haven't covered all cases of closing and opening the modal but test around and see how it behaves...