Dec2020 small updates #140
Conversation
Updated information page to display new TDList information in full.
Added tournament ratings steps
Add space between chapter info and members
| @@ -46,7 +46,7 @@ <h2> Chapter: {{ chapter.code }} </h2> | |||
| <dt> Website: </dt> <dd> <a href="{{chapter.url}}">{{ chapter.url }}</a> </dd> | |||
| {% endif %} | |||
| </dl> | |||
|
|
|||
| <p></p> | |||
There was a problem hiding this comment.
Can you do something different here for your formatting? I am not sure we should be using <p> and </p> tags here if we are looking for a line break. CSS or Inline style maybe?
There was a problem hiding this comment.
I could add a double break line
in its place. Wanted just a large spacing there.
| .style("text-anchor", "end") | ||
| .text("total # of Games"); | ||
| .style("text-anchor", "start") | ||
| .text("Total # of Games"); |
There was a problem hiding this comment.
Looking at this a second time. I don't think we need the "Total # of Games" or "# of Games" on both sides. I think we could do with just the one on the left with your new label "Total # of Games" vs "# of Games."
There was a problem hiding this comment.
One has been hidden so people dont like the graph. Trying to fix the graph to correctly show what it is until we can overhaul it with other info as per #122 .
There was a problem hiding this comment.
My issue is that we are introducing a new issue here, so now we have the label on both sides. One of which may be obscured by our graph in production.
There was a problem hiding this comment.
I think I was playing with it on the test server and then replicating it for my git files tbh. The right side test should still sit below the graph lines.
There was a problem hiding this comment.
I checked the test server, and I am seeing an error 500, so I have reverted that. If you would like to mess with this locally, try doing so with $ docker-compose up --build --force recreate. You should be able to download the schema from https://github.com/usgo/usgo-sql-schemas. There are instructions for basic docker-compose operations on: https://github.com/usgo/agagd/blob/master/docs/docker.md. The only two files that are really needed to run $ docker-compose up are: schema.sql and config-docker.env. It may be finicky on the values for config-docker.env. Let me know if you have any issues.
Otherwise, the change does make sense.
| <li>Tournament Directors: <br> | ||
| <table> | ||
| <tr> | ||
| <th>TD List Name</th> | ||
| <th><a href="https://usgo.org/mm/tdlista.txt">TDListA</a></th> | ||
| <th><a href="https://usgo.org/mm/tdlistb.txt">TDListB</a></th> | ||
| <th><a href="https://usgo.org/mm/tdlistn.txt">TDListN</a></th> | ||
| </tr><tr> | ||
| <th>Delimiter</th> | ||
| <th>Tab</th> | ||
| <th>Tab</th> | ||
| <th>Tab</th> | ||
| </tr><tr> | ||
| <th>Columns displayed</th> | ||
| <th>MememberName AGAID MememberType Rating RenewalDue ChapterCode State Sigma RatingUpdated</th> | ||
| <th>MememberName AGAID MememberType Rating RenewalDue ChapterName State Sigma RatingUpdated</th> | ||
| <th>MememberName AGAID MememberType Rating RenewalDue ChapterCode State || Fixed Width</th> | ||
| </tr> | ||
| </table> </li> |
There was a problem hiding this comment.
In my opinion, I think these should be a little clearer that we are using tab delimitation for our TDLists.
I think we could do something about the presentation of the table and it should be a different section. Under the bullet list may not be clear to some.
There was a problem hiding this comment.
Youre right, I was writing these one way and they need to be the other way. I will resubmit this.
Updated to better show information
| @@ -26,7 +26,25 @@ <h2>Additional Information</h2> | |||
| <li>Answers to the <a href="https://www.usgo.org/files/pdf/ratingquestions.pdf">most commonly asked questions about the rating system</a> (May 1992)</li> | |||
| <li>A more detailed <a href="https://www.usgo.org/files/pdf/AGARatings-Math.pdf">mathematical description</a> of the ratings system (April 2010)</li> | |||
| <li><a href="https://www.usgo.org/files/pdf/bayrate.zip">Source code</a> for the AGA rating algorithm</li> | |||
| <li>Tournament Directors: <a href="https://usgo.org/mm/tdlista.txt">TDListA</a> <a href="https://usgo.org/mm/tdlistn.txt">TDListN</a></li> | |||
| <li>Tournament Directors: <br> | |||
There was a problem hiding this comment.
We would probably do better moving the title into an <h3></h3> or another header; then moving the table beneath that and having the label "TDLists Formating." May be change the label for "Additional information" to "Resources."
There was a problem hiding this comment.
The page probably needs an overhaul of info anyways. Next update?
There was a problem hiding this comment.
Yes. We could just move this forward, and on the next update the page can be overhauled.
| @@ -46,7 +46,7 @@ <h2> Chapter: {{ chapter.code }} </h2> | |||
| <dt> Website: </dt> <dd> <a href="{{chapter.url}}">{{ chapter.url }}</a> </dd> | |||
| {% endif %} | |||
| </dl> | |||
|
|
|||
| <br><br> | |||
There was a problem hiding this comment.
I don't mind having two breaks. I just think that one may may the new version softer compared with the present change. The new and old screenshots are just references to #140's new change and our current version.
New
Old
There was a problem hiding this comment.
One Two, As long as theres a slight break between the two I think it looks better to break up the sections. Unlike the odd way that last sentence is structured.
There was a problem hiding this comment.
I have updated my comment: #140 (comment) to make more sense.
Updates to: main page graph for clarity, spacer in chapter view, tournament info information, tournament quals information.