Abort type-check when dependencies have parse errors. #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavyLandman
requested changes
Oct 20, 2025
rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/IDECheckerWrapper.rsc
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/IDECheckerWrapper.rsc
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/IDECheckerWrapper.rsc
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/IDECheckerWrapper.rsc
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/rascal/RascalLanguageServices.java
Outdated
Show resolved
Hide resolved
toinehartman
force-pushed
the
fix/832-duplicate-parse-error
branch
from
bbd7c59 to
512ff7f
Compare
DavyLandman
reviewed
Oct 28, 2025
rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/IDECheckerWrapper.rsc
Outdated
Show resolved
Hide resolved
DavyLandman
approved these changes
Oct 28, 2025
toinehartman
force-pushed
the
fix/832-duplicate-parse-error
branch
from
4e76003 to
746a666
Compare
toinehartman
force-pushed
the
fix/832-duplicate-parse-error
branch
4 times, most recently
from
b6a7179 to
648d074
Compare
toinehartman
force-pushed
the
fix/832-duplicate-parse-error
branch
from
133e3ed to
da420b1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recovered parse error
Shows 1 cause per disambiguated error tree
Fatal parse error
Shows 1 cause for the file with an error
Closes #832