Upgrade/remove dependency curl-ev and migrating some deprecation cURL… #883
+2,277
−1,347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apolukhin
requested changes
Mar 13, 2025
| } // namespace curl | ||
|
|
||
| namespace clients::http { | ||
|
|
||
| #if LIBCURL_VERSION_NUM <= 0x074700 | ||
| class Form final { |
There was a problem hiding this comment.
I think we have a few thousands usages of Form in our internal codebase. It can not be removed, but its implementation should be transparent ly replaced.
| bool auth_only, | ||
| std::string_view user, | ||
| std::string_view password | ||
| ) { | ||
| easy().set_http_auth(value, auth_only); | ||
| easy().set_user(std::string{user}.c_str()); |
| @@ -34,106 +33,200 @@ | |||
| USERVER_NAMESPACE_BEGIN | |||
|
|
|||
| namespace curl { | |||
| namespace { | |||
| namespace detail { | |||
There was a problem hiding this comment.
There are too many changes, many of them are unrelated to the task.
Stick to the rule ”one problem - one PR". Otherwise we wont be able to review the PR in a reasonable time and we wont be able to merge it (because it wouod definitely break somerlthin in our internal code base).
Revert all the changes that are not related to the Form deprecation problem
core/src/curl-ev/mime.cpp
Outdated
| @@ -0,0 +1,23 @@ | |||
| // !TODO this @file curl-ev/mime.cpp create in 2025 year // | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #867
edit unused functions ~/clients/http/request.hpp and request.cpp
comment unused new version deprecated function Request::form(Form&& form); and
create new function mark [[maybe_unused]] Request::mime(Mime&& mime);
Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.