Skip to content

Conversation

@JustSxm
Copy link

@JustSxm JustSxm commented Nov 12, 2025

Description

This fixes an issue where moving something from todo -> done is not being updated on github and closed. This also fixes the more general bug where the status is not updated unless changed from the card itself.

Related Issue(s)

Fixes #637

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test addition or update
  • Other (please describe):

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual testing
  • Other (please describe):

Screenshots (if applicable)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Notes

@github-actions github-actions bot requested a review from aacevski November 12, 2025 01:54
@JustSxm JustSxm changed the title fix: Fixfix: Status not updating when moved in the grid fix: Status not updating when moved in the grid Nov 12, 2025
@JustSxm JustSxm force-pushed the fix/status-not-updating branch from 28208f2 to cbbe399 Compare November 12, 2025 02:00
@JustSxm
Copy link
Author

JustSxm commented Nov 12, 2025

PS : I took the liberty to update the return from updatedTask to existingTask because when updating only status from update-task-status.ts we do the same thing. Do we actually need to return the task ?

@savio-henrique
Copy link
Contributor

savio-henrique commented Nov 13, 2025

Do we actually need to return the task ?

In my opinion, the return of an update function should always be the updated object. Because, in that way, you're just returning the unaltered object.

@JustSxm
Copy link
Author

JustSxm commented Nov 13, 2025

I agree with that, but right now that is not what is being done. If we don't have a reason to return the updated object, shouldn't we just return nothing

@savio-henrique
Copy link
Contributor

If the default is to return the obsolete object, then its best to continue with this pattern, until a better refactoring is done to update all returns of 'put' endpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Moving an issue to "Done" does not close the issue on github

3 participants