Skip to content

Conversation

mdqst
Copy link

@mdqst mdqst commented Aug 26, 2025

Summary

Closes #_

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on a specific version of cargo-contract or pallet-revive?

Description

fixed the grep so it finds #[ink::contract] even if it’s indented or has spaces.
the old one missed those cases.

Checklist before requesting a review

  • I have added an entry to CHANGELOG.md
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@cmichi
Copy link
Collaborator

cmichi commented Aug 29, 2025

@mdqst Can you merge master into your PR?

@mdqst
Copy link
Author

mdqst commented Aug 29, 2025

cmichi, I’m using the web version of GitHub and don’t see the Update branch button.
could you clarify if my branch is already up to date with master, or should I update it locally?

@cmichi
Copy link
Collaborator

cmichi commented Sep 8, 2025

cmichi, I’m using the web version of GitHub and don’t see the Update branch button. could you clarify if my branch is already up to date with master, or should I update it locally?

Your branch is not up to date with master, I'm not sure if you can update it via the web ui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants