Update cargo-contract crate versions #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
you probably have to add something like |
|
Here is a solution to this very annoying problem: use-ink/cargo-contract#1416. |
Collaborator
|
Don't forget to bump drink! version as well. |
pmikolajczyk41
approved these changes
Dec 4, 2023
deuszx
reviewed
Dec 4, 2023
Comment on lines
+27
to
+29
| contract-build = { version = "4.0.0-rc.1" } | ||
| contract-metadata = { version = "4.0.0-rc.1" } | ||
| contract-transcode = { version = "4.0.0-rc.1" } |
Collaborator
There was a problem hiding this comment.
I just noticed that - I don't think the main release of drink! to crates should be done against release candidates. There are other projects that depend on drink! from crates.io and they might get silently broken now.
Judging from the diff though - there aren't that many changes. Does it mean ink5 is backwards comptible with ink4 ?
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of ink! 5.0.0-rc and cargo-contract 4.0.0-rc we need to update
drinkdependency in order to publish the updated version ofink_e2ecrate.