Skip to content

Trim stracktrace on bail:meme#991

Closed
dozreg-toplud wants to merge 2 commits into
developfrom
dozreg/trace-meme-crash
Closed

Trim stracktrace on bail:meme#991
dozreg-toplud wants to merge 2 commits into
developfrom
dozreg/trace-meme-crash

Conversation

@dozreg-toplud
Copy link
Copy Markdown
Contributor

@midden-fabler noticed that the runtime process would occasionaly get aborted if a bail:meme involved large stacktrace - it would be too big to copy out in _cm_stack_unwind, causing us to bail:meme on the home road again.

This PR adds stack trace trimming on the deepmost road if we crash with meme moat and the stacktrace happens to be bigger than 1024 frames. It stitches up the beginning and the ending parts with [%mean 'meme: trace'] which would typically get cut off by +mook anyway. Such operations on the stacktrace are safe for the nondeterministic crashes, as documented in the comment.

Note: for this to work end must be a subnoun of beg, which should be true considering the comparisons I used.

@dozreg-toplud dozreg-toplud requested a review from a team as a code owner April 1, 2026 12:03
@dozreg-toplud dozreg-toplud changed the title Dozreg/trace meme crash Trim stracktrace on bail:meme Apr 1, 2026
@dozreg-toplud dozreg-toplud requested a review from joemfb April 1, 2026 12:04
@dozreg-toplud
Copy link
Copy Markdown
Contributor Author

And to reproduce the issue, run this in Dojo:

!:  |-($)

@dozreg-toplud
Copy link
Copy Markdown
Contributor Author

closing in favor of #993; this particular fix wouldn't work without mug clearing / use_w assertions since the trace is injected into Arvo later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant