Trim stracktrace on bail:meme#991
Closed
dozreg-toplud wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
And to reproduce the issue, run this in Dojo: |
Contributor
Author
|
closing in favor of #993; this particular fix wouldn't work without mug clearing / |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@midden-fabler noticed that the runtime process would occasionaly get aborted if a
bail:memeinvolved large stacktrace - it would be too big to copy out in_cm_stack_unwind, causing us tobail:memeon the home road again.This PR adds stack trace trimming on the deepmost road if we crash with
mememoat and the stacktrace happens to be bigger than 1024 frames. It stitches up the beginning and the ending parts with[%mean 'meme: trace']which would typically get cut off by+mookanyway. Such operations on the stacktrace are safe for the nondeterministic crashes, as documented in the comment.Note: for this to work
endmust be a subnoun ofbeg, which should be true considering the comparisons I used.