This repository was archived by the owner on May 12, 2023. It is now read-only.
Naoiss Homework 3 (Bugra) #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upy
reviewed
Dec 12, 2021
Owner
upy
left a comment
upy
left a comment
There was a problem hiding this comment.
create durumlarinda yazdigimiz basket.add, customer.add gib tanimlarin hata verdigini gormemizde fayda var.
| class BasketSerializer(serializers.ModelSerializer): | ||
| class Meta: | ||
| model = Basket | ||
| read_only_fields = ['id', 'created_at', 'updated_at'] |
Owner
There was a problem hiding this comment.
bu alanlar zaten read_only degil mi?
| serializer = CustomerSerializer(data=customer) | ||
| serializer.is_valid(raise_exception=True) | ||
| serializer.save() | ||
| basket.customer.add(*serializer.instance) |
Owner
There was a problem hiding this comment.
sepet eklerken customer eklenmesi cok kullanisli gozukmiyor sanki?
| product = ProductDetailedSerializer() | ||
|
|
||
| @atomic() | ||
| def create(self, validated_data): |
Owner
There was a problem hiding this comment.
genelde (ozel durumlar haric) detailed'lar ile create/update islemleri yapmamayi tercih ediyoruz.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEWORK 3
set serializers and filters, conf views and urls
Ömer Buğra Yıldırım