DX-1660: add EVAL_RO and EVALSHA_RO commands #1365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| createScript(script: string): Script { | ||
| return new Script(this, script); | ||
| createScript(script: string): Script; | ||
| createScript(script: string, opts: ScriptOptions & { readOnly: true }): ScriptRO; |
There was a problem hiding this comment.
ScriptOptions is already
ScriptOptions = {
readOnly?: boolean;
};
until we add new options, i think we don't need it here, it duplicates rn
There was a problem hiding this comment.
You are saying we should remove ScriptOptions here right? Because { readOnly: true } helps with the type safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.