fix: Controlplane spec.class improvements #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lsviben
changed the title
turkenh
approved these changes
Oct 18, 2024
sttts
reviewed
Oct 18, 2024
sttts
reviewed
Oct 18, 2024
sttts
approved these changes
Oct 18, 2024
Signed-off-by: lsviben <[email protected]>
Signed-off-by: lsviben <[email protected]>
lsviben
force-pushed
the
describe-class
branch
from
71bafb6 to
6eff20e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add a better description for control plane spec.class and updates the classes gate flag to the current proposed one in https://github.com/upbound/spaces/pull/1916/files#r1805980906
I have:
make reviewableto ensure this PR is ready for review.[ ] Addedbackport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
N/A