Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Simulation API types #110
Add Simulation API types #110
Changes from all commits
3eccbd7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it edit
spec.desiredState
?What if the user already set it to
Complete
orTerminated
in the beginning? WouldCompletionCriteria
be ignored then? Any practical reason for someone to set it any value other thanAcceptingChanges
? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will.
Yes, if the simulation is already complete (or terminated) the completion criteria are ignored.
You mean
spec.desiredState
? If so:You'd set
spec.desiredState
to Complete to manually mark the simulation complete, and thus trigger detection of the changes that happened while it was accepting changes. In this case you'd probably leave the completion criteria empty. Though you could also set the completion criteria to say 10 minutes but then later decide to manually mark the simulation complete (by changingspec.desiredState
after 5 minutes.You'd set
spec.desiredState
to Terminated to terminate the simulation. This is the only way a simulation can be terminated. (A terminated simulation no longer has a control plane, but still exists so you can see the change summary in status.)I'm open to updating the comment if there's a relatively succinct way to make this clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how I feel about defaulting this to Duration.
Right now it's the only choice, but I think we'll add more values in future. I don't think we'd make duration the default once there are more options - there wouldn't be a default. So feel it could be surprising to users to make it the default now, but then not in future. It's a subtle difference, but I think I prefer requiring folks to explicitly specify the one allowed value.