Add condition status to SharedSecretStoreStatus #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean du Plessis <[email protected]>
jeanduplessis
force-pushed
the
shared-secret-store-status
branch
from
d38f01c to
9df5f9b
Compare
phisco
requested changes
Aug 5, 2024
Signed-off-by: Jean du Plessis <[email protected]>
jeanduplessis
force-pushed
the
shared-secret-store-status
branch
from
9df5f9b to
6893275
Compare
phisco
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This is simply a recreation of #90 since the fork is no longer available.
@phisco I've also tried to address your review feedback in this PR, see the last commit.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested