-
Notifications
You must be signed in to change notification settings - Fork 0
Added reports navigation Item in sidebar #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
09fb22a
feat: added controller, views, tests for reports
AliK070 8f8abeb
Merge branch 'main' into report-index-page
AliK070 ee29de6
Merge branch 'main' into report-index-page
AliK070 18fc9ae
Merge branch 'report-index-page' of https://github.com/uoftblueprint/…
AliK070 dd5ef7e
Merge branch 'main' into report-index-page
AliK070 8cac48f
fix(reports): edited report creation and focused on the Index route.
AliK070 485e52c
Merge branch 'main' into report-index-page
AliK070 f9a275f
fix(reports): removed icon and headers.
AliK070 908d44d
fix(sidebar): add reports navigation item and locale keys
AliK070 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <div class="mx-8 my-10"> | ||
| <div class="flex items-center justify-between mb-4"> | ||
| <h1 class="text-4xl font-bold"><%= t(".title") %></h1> | ||
| <%= render ActionButtonComponent.new(to: new_report_path, icon: "add", colour: :primary, size: :large) do %> | ||
| <%= t(".actions.create") %> | ||
| <% end %> | ||
| </div> | ||
| <%= render ContentCardComponent.new do %> | ||
| <%= render Shared::IndexTableComponent.new(records: @reports) do |table| %> | ||
| <% table.column :start_date do |report| %> | ||
| <%= l(report.start_date) if report.start_date %> | ||
| <% end %> | ||
| <% table.column :end_date do |report| %> | ||
| <%= l(report.end_date) if report.end_date %> | ||
| <% end %> | ||
| <% table.column :created_at do |report| %> | ||
| <%= l(report.created_at) %> | ||
| <% end %> | ||
| <% table.column :actions, header: t("shared.index_table_component.actions"), col_size: "90px" do |report| %> | ||
| <div class="flex flex-row gap-2 items-center"> | ||
| <%= render ActionButtonComponent.new(to: report_path(report), icon: "view") %> | ||
| <%= render ActionButtonComponent.new(to: edit_report_path(report), icon: "edit", colour: :info) %> | ||
| <%= render ActionButtonComponent.new(to: report_path(report), method: :delete, icon: "delete", colour: :error, confirm: t("reports.destroy.confirm")) %> | ||
| </div> | ||
| <% end %> | ||
| <% end %> | ||
| <% end %> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reports = Report.allwill load and render every report, andShared::IndexTableComponentrenders all provided records into the DOM (client-side pagination/filtering). This is unbounded and can degrade performance as the reports table grows; consider ordering and adding server-side limiting/pagination (e.g.,order(created_at: :desc)plus real pagination) before passing records to the table.