Skip to content

Adds phased_restart:or_start and restart:or_start tasks#20

Open
hovancik wants to merge 1 commit into
untitledkingdom:masterfrom
hovancik:feature/restart_or_start
Open

Adds phased_restart:or_start and restart:or_start tasks#20
hovancik wants to merge 1 commit into
untitledkingdom:masterfrom
hovancik:feature/restart_or_start

Conversation

@hovancik

@hovancik hovancik commented Mar 22, 2017

Copy link
Copy Markdown

rationale

When I deploy app with mina-puma, I want to be able to use one command to restart (or start app if needed). With tasks available right now, it's not possible, so to check whether app is running I would need to bring extra stuff, that is already in mina-puma (eg. :pumactl_socket ), to my deploy.rb.

changes done

pumactl_command was extended to accept one more parameter or_start, which defaults to false, so no changes needs to be done to current code. Whenor_start is set to true, app will be started when not running.

New tasks restart:or_start and phased_restart:or_start were added utilising this functionality.

Please let me know if that's fine, or you can see a better way to do it. Then I can update README and so on.

@windy

windy commented Aug 4, 2018

Copy link
Copy Markdown

+1

@windy

windy commented Feb 26, 2019

Copy link
Copy Markdown

@hovancik I refactor it to mina-ng-puma here:

https://github.com/windy/mina-ng-puma

phased_restart and restart need start puma correctly when puma is down.

@jmuheim

jmuheim commented Oct 2, 2019

Copy link
Copy Markdown

Is this gem still under maintenance? I have invested many hours to make it run, and I find the README could be a bit more exhaustive (e.g. I did not find anything about puma_port setting until I dug into the code itself).

If I add details to the README, would this PR possibly be merged? If not, what about https://github.com/windy/mina-ng-puma, is it still maintained and would embrace PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants