Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/load-checkpoint-add-new-tokens #1225

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix/load-checkpoint-add-new-tokens #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions unsloth/models/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
from transformers import __version__ as transformers_version
from peft import PeftConfig, PeftModel
from .mapper import INT_TO_FLOAT_MAPPER, FLOAT_TO_INT_MAPPER, MAP_TO_UNSLOTH_16bit
from ..tokenizer_utils import add_new_tokens
import os
try:
from huggingface_hub.utils import get_token
Expand Down Expand Up @@ -349,6 +350,16 @@ def from_pretrained(
model.resize_token_embeddings(resize_model_vocab)
pass

# Check if tokenizer is updated -> Add tokens in process
# Only for PEFT -> Assume it's checkpoint since checkpoit only saves adapter
if is_peft and model_config.vocab_size < len(tokenizer.vocab):
logger.warning_once(
"Unsloth: Your model's vocab size is less than the tokenizer's vocab size.\n"\
"We shall add the new tokens to the model's vocab."
)
add_new_tokens(model, tokenizer, resize_tokenizer = False)


# In case the model supports tagging, add the unsloth tag.
if hasattr(model, "add_model_tags"):
model.add_model_tags(["unsloth",])
Expand Down