Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove background after scale #39

Merged
merged 9 commits into from
May 6, 2024

Conversation

cpreston321
Copy link
Contributor

Fixes: #38

Copy link

changeset-bot bot commented Apr 12, 2024

🦋 Changeset detected

Latest commit: bf2e905

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vaul-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zernonia
Copy link
Member

Thanks for the PR @cpreston321 !!

Your solution might not be the best fitted here as we want the background color to run animation first before resetting it.
I found out that we are missing some code here from the original repo.

https://github.com/emilkowalski/vaul/blob/7e340d342521edf604bd68cc1cdbc0b8a70f66b8/src/index.tsx#L612-L623

https://github.com/emilkowalski/vaul/blob/7e340d342521edf604bd68cc1cdbc0b8a70f66b8/src/index.tsx#L437-L446

Can you try and see if the above fix the background styling issue? 😁

@cpreston321
Copy link
Contributor Author

@zernonia Sorry I was not looking at the upstream repo at first, this should fix it now. Thank you.

@zernonia
Copy link
Member

@cpreston321 can you help provide some case on how to test the above ya? Actually I'm not sure how to recreate the issue where background not reset after scale

@zernonia zernonia merged commit e22af4d into unovue:main May 6, 2024
1 check passed
@cpreston321 cpreston321 deleted the fix/resetBackgroundState branch June 14, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background black is not removed from body on close
2 participants