Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts types for headingValue in CalendarHeading and `RangeCalendarHeading components #981

Closed
wants to merge 4 commits into from

Conversation

n1crack
Copy link

@n1crack n1crack commented Dec 27, 2024 β€’

πŸ”— Linked issue

Resolves #638

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)

πŸ“š Description

This pull request addresses a TypeScript typing issue in the CalendarHeading component where headingValue was implicitly typed as any. The solution ensures explicit typing of the slot props, preventing further TypeScript errors and improving type safety.

  • Refactored v-slot usage to explicitly declare the type of headingValue as string.
  • Added proper TypeScript annotations for slot props, ensuring compatibility with both Vue 3's template syntax and TypeScript's inference.

Btw, I'm using Inertia.js with vite 6.0 with strict types

πŸ“Έ Screenshots (if appropriate)

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

@n1crack n1crack changed the title 🐞 Fix ts types for headingValue in CalendarHeading and `RangeCalendarHeading components fix: ts types for headingValue in CalendarHeading and `RangeCalendarHeading components Dec 27, 2024
@sadeghbarati
Copy link
Collaborator

Thanks for the PR πŸ™

This PR also fixes this issue in new-york style too #1038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Property 'heading' does not exist on type
2 participants