feat: add common theme constants library (Uno.Toolkit.WinUI.Themes.Markup) #437
Conversation
agaldanaw2
changed the title
|
|
||
| public static class Chip | ||
| { | ||
| public static class Assist |
There was a problem hiding this comment.
would it make more sense to group by: default/normal vs elevated?
| public static class AppBarButton | ||
| { | ||
| [ResourceKeyDefinition(typeof(Style), "MainCommandStyle", TargetType = typeof(AppBarButton))] | ||
| public static ResourceValue<Style> Default => new("MainCommandStyle"); |
There was a problem hiding this comment.
maybe we could have keep the original name, and then have a default alias that points to it:
[...] public static Default => Main;
[...] public static Main => new(...);
| <PackageVersion Include="Uno.Themes.WinUI.Markup" Version="2.5.0-dev.3" /> | ||
| <PackageVersion Include="Uno.WinUI.Markup" Version="4.6.0-dev.14" /> |
There was a problem hiding this comment.
these will need to be updated due to breaking changes in Uno.Extensions.Markup. See unoplatform/Uno.Themes/pull/906
There was a problem hiding this comment.
let's be sure to update these dependencies
|
@dansiegel, I feel like we put this aside before the break for some reason but I can't remember. Other than the required changes to update the package references, we can probably get this merged soon, right? |
|
|
||
| namespace Uno.Toolkit.Themes.Markup | ||
| { | ||
| public static partial class Theme |
There was a problem hiding this comment.
Should this perhaps be called ToolkitTheme... I feel like calling it Theme would lead to conflicts with the main Theme class for Uno.Themes
GitHub Issue (If applicable): #389
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Add common theme constants library (Uno.Toolkit.WinUI.Themes.Markup)
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):
#389