fix: disable x86 on Android to try to stay below size limits

unomed-dev · Jan 29, 2025 · 54ca156 · 54ca156
1 parent 58b948f
commit 54ca156
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/android/build.gradle b/android/build.gradle
@@ -78,7 +78,7 @@ android {
       }
     }
     ndk {
-      abiFilters "arm64-v8a", "armeabi-v7a", "x86", "x86_64"
+      abiFilters "arm64-v8a", "armeabi-v7a", "x86_64"
     }
   }
 

diff --git a/example/android/gradle.properties b/example/android/gradle.properties
@@ -25,7 +25,8 @@ android.useAndroidX=true
 # Use this property to specify which architecture you want to build.
 # You can also override it from the CLI using
 # ./gradlew <task> -PreactNativeArchitectures=x86_64
-reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
+# TODO: Include x86
+reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86_64
 
 # Use this property to enable support to the new architecture.
 # This will allow you to use TurboModules and the Fabric render in

diff --git a/ubrn.yaml b/ubrn.yaml
@@ -10,7 +10,8 @@ android:
   targets:
     - arm64-v8a
     - armeabi-v7a
-    - x86
+    # x86 should only be needed for ancient devices and excluding this helps us stay below npmjs size limits
+    # - x86
     - x86_64
 ios:
   cargoExtras: []
-Original file line number
+Diff line change
@@ Expand Up / @@ -78,7 +78,7 @@ android { @@
           }
         }
         ndk {
-          abiFilters "arm64-v8a", "armeabi-v7a", "x86", "x86_64"
+          abiFilters "arm64-v8a", "armeabi-v7a", "x86_64"
         }
       }
@@ Expand Down @@