fix: apply success filter

[chronark]

the filter was piped through as 'success' but our clickhouse query
expected 'passed'

Summary by CodeRabbit

• Bug Fixes

  • Updated rate limit logs query to correctly filter and display log entries
  • Improved query construction for more accurate log retrieval

• Refactor

  • Streamlined the rate limit logs query logic
  • Enhanced query parameter handling for better performance and readability

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 14, 2025 10:18am
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 14, 2025 10:18am
play	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 14, 2025 10:18am
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 14, 2025 10:18am

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1f79e01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request involves modifications to the rate limits logging functionality across two files: the dashboard page and the ClickHouse query implementation. The primary change is renaming the success parameter to passed in both the frontend and backend components. This update affects how rate limit logs are queried and displayed, ensuring consistency in the parameter naming between the UI and database query layers.

Changes

File	Change Summary
apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/page.tsx	Renamed success to passed in query object and table header
internal/clickhouse/src/ratelimits.ts	Refactored getRatelimitLogs function to use a more streamlined query construction and updated parameter handling

Possibly related PRs

• refactor: query audit logs from planetscale #2181: Modifications to AuditLogTable component log querying
• fix: Replaced clear button with reset filters button #2703: Filter reset functionality for audit logs
• fix: ratelimit date input and time display logs #2717: Changes to page.tsx log rendering

Suggested Labels

bug, needs-approval

Suggested Reviewers

• mcstepp
• ogzhanolguncu
• perkinsjr

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f87f0ff and 1f79e01.

📒 Files selected for processing (2)

• apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/page.tsx (2 hunks)
• internal/clickhouse/src/ratelimits.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (17)

• GitHub Check: Test Packages / Test ./packages/rbac
• GitHub Check: Test Packages / Test ./packages/nextjs
• GitHub Check: Test Packages / Test ./packages/hono
• GitHub Check: Test Packages / Test ./packages/cache
• GitHub Check: Test Packages / Test ./packages/api
• GitHub Check: Test Packages / Test ./internal/clickhouse
• GitHub Check: Test Packages / Test ./internal/resend
• GitHub Check: Test Packages / Test ./internal/keys
• GitHub Check: Test Packages / Test ./internal/id
• GitHub Check: Test Packages / Test ./internal/hash
• GitHub Check: Test Agent Local / test_agent_local
• GitHub Check: Test Packages / Test ./internal/encryption
• GitHub Check: Test Packages / Test ./internal/billing
• GitHub Check: Test API / API Test Local
• GitHub Check: Build / Build
• GitHub Check: autofix
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (4)

internal/clickhouse/src/ratelimits.ts (2)

187-196: LGTM! Proper schema validation and execution setup.

The implementation includes proper type validation using Zod schema and follows the repository's patterns for query execution.

---

171-186: LGTM! Query construction looks clean and secure.

The SQL query is well-structured with proper parameterization and conditional filtering.

Let's verify the column naming consistency in the ClickHouse schema:

✅ Verification successful

Column naming verified and consistent with schema

The passed column is correctly defined as Bool in the raw_ratelimits_v1 table, which matches the query's usage. The column name is consistently used across all related tables in the schema.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the column name is consistently 'passed' across all tables

# Check column names in all ratelimit tables
ast-grep --pattern 'CREATE TABLE $table (
  $$$
  passed $type $$$
  $$$
)'

Length of output: 77

---

Script:

#!/bin/bash
# First, find SQL files or schema definitions
fd -e sql

# Then search for ratelimit table definitions and 'passed' column
rg -i "create.*table.*ratelimit" -A 10
rg "passed.*boolean" -A 2 -B 2

Length of output: 12649

apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/page.tsx (2)

84-84: Simple text update in breadcrumb navigation.

---

153-153: LGTM! Parameter renamed from 'success' to 'passed' as intended.

This change aligns the frontend query parameter with the ClickHouse column name, fixing the filter functionality.

Let's verify that all references to 'success' have been updated:

✅ Verification successful

Parameter renaming is correctly implemented and localized

The change safely maps the internal success state to the external passed parameter at the API request level, maintaining consistency with the ClickHouse column name while preserving the existing state management.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining references to 'success' that might need updating

# Search for 'success' in relevant contexts
rg 'success' --type ts --type tsx

# Look specifically for filter-related patterns
ast-grep --pattern 'success: $value'

Length of output: 100

---

Script:

#!/bin/bash
# Search in both .ts and .tsx files with context
rg -t ts -t tsx 'success' -C 2

# Look for specific patterns in the abstract syntax tree
ast-grep --pattern 'success: $_'
ast-grep --pattern '$_.success'
ast-grep --pattern 'success\?:'

Length of output: 31871

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏