Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding changelog december #2782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

perkinsjr
Copy link
Collaborator

@perkinsjr perkinsjr commented Dec 27, 2024

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • New Features
    • Added a changelog entry for December 5th, 2024, detailing updates to the Unkey API and Python SDK.
    • Introduced the concept of Identities for grouping keys and sharing metadata.
    • New API endpoint to retrieve details about an API key.
    • Added functionality for creating identities and managing ratelimit overrides via the API.
    • Enhanced Python SDK with new methods for key creation and identity management.

Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: 3163871

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 11:10pm
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 11:10pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 11:10pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 11:10pm

Copy link
Contributor

coderabbitai bot commented Dec 27, 2024

📝 Walkthrough

Walkthrough

The changelog introduces significant updates to the Unkey platform, focusing on the new official Python SDK, the concept of Identities, and enhanced ratelimit management. The changes include a new SDK for key management, a method to create keys with detailed configurations, an endpoint to retrieve key details, and the ability to create and manage identities. Users can now group keys, set shared metadata and rate limits, and programmatically manage ratelimit overrides.

Changes

File Change Summary
apps/www/content/changelog/2024-12-06.mdx Added changelog entry for December 5th, 2024 detailing Python SDK, Identities, and Ratelimit Overrides

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant SDK as Unkey Python SDK
    participant API as Unkey API
    
    Dev->>SDK: Create Key
    SDK->>API: POST /v1/keys.createKey
    API-->>SDK: Key Created
    
    Dev->>SDK: Create Identity
    SDK->>API: POST /v1/identities.createIdentity
    API-->>SDK: Identity Created
    
    Dev->>SDK: Attach Key to Identity
    SDK->>API: Update Key with External ID
    API-->>SDK: Key Updated
    
    Dev->>SDK: Verify Key Details
    SDK->>API: POST /v1/keys.whoami
    API-->>SDK: Key Information
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (3)
apps/www/content/changelog/2024-12-06.mdx (3)

17-18: Simplify import statements

The code imports the same package twice in different ways.

-import unkey
-from unkey_py import Unkey
+from unkey_py import Unkey

122-139: Enhance response example documentation

Consider adding comments to explain the significance of each field in the response, particularly the identity and meta objects.

 {
+  // Unique identifier for the key
   "id": "key_123",
+  // Display name of the key
   "name": "API Key 1",
+  // Number of remaining uses (if limited)
   "remaining": 1000,
+  // Associated identity information
   "identity": {
     "id": "id_123",
     "externalId": "ext123"
   },
+  // Custom metadata associated with the key
   "meta": {
     "role": "admin",
     "plan": "premium"
   },
   "createdAt": 1620000000000,
   "enabled": true,
   "environment": "production"
 }

150-156: Document the async flag

The example includes an async flag but its purpose and implications aren't explained. Consider adding documentation about when to use async: true vs async: false.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1115fd5 and 3163871.

📒 Files selected for processing (1)
  • apps/www/content/changelog/2024-12-06.mdx (1 hunks)
🧰 Additional context used
🪛 Gitleaks (8.21.2)
apps/www/content/changelog/2024-12-06.mdx

69-72:

(curl-auth-header)


93-96:

(curl-auth-header)


113-115:

(curl-auth-header)


145-148:

(curl-auth-header)

🔇 Additional comments (1)
apps/www/content/changelog/2024-12-06.mdx (1)

73-88: Review token ratelimit duration

The tokens ratelimit has a very low duration of 10 seconds with a high limit of 86,400,000. This seems unusual and might be reversed with the limit value.

Please verify if these values are intentional or if they should be adjusted.

apps/www/content/changelog/2024-12-06.mdx Show resolved Hide resolved
apps/www/content/changelog/2024-12-06.mdx Show resolved Hide resolved
apps/www/content/changelog/2024-12-06.mdx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant