Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move docs #369

Merged
merged 18 commits into from
Mar 9, 2024
Merged

docs: move docs #369

merged 18 commits into from
Mar 9, 2024

Conversation

yuyinws
Copy link
Contributor

@yuyinws yuyinws commented Mar 7, 2024

πŸ”— Linked issue

unplugin/docs#7

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR includes:

  1. Move unplugin/docs to this repo.
  2. Add a new GitHub workflows file. Ensure that Vercel automatic build is triggered every time the main branch is updated.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@yuyinws yuyinws marked this pull request as ready for review March 7, 2024 01:27
@yuyinws
Copy link
Contributor Author

yuyinws commented Mar 7, 2024

@sxzz Hi, Once this PR merge. I will dm you in discord about the GitHub action secrets like VERCEL_TOKEN.

@sxzz
Copy link
Member

sxzz commented Mar 7, 2024

@antfu Could you please grant me the admin access of repo.

.npmrc Outdated
@@ -0,0 +1,3 @@
ignore-workspace-root-check=true
shamefully-hoist=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid shamefully-hoist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After remove it, vitepress build get some error throw by twoslash.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because unplugin itself wasn't built.

@sxzz
Copy link
Member

sxzz commented Mar 8, 2024

I plan to move it to Netlify by using Anthony's or Unjs org's account, since we cannot manage the website in an organization if deployed in Vercel.

@yuyinws
Copy link
Contributor Author

yuyinws commented Mar 9, 2024

After the new site is available, I will let the old domain redirect to the new one.

@antfu antfu merged commit 83d6795 into unjs:main Mar 9, 2024
10 checks passed
@sxzz
Copy link
Member

sxzz commented Mar 12, 2024

@yuyinws New docs have landed on https://unplugin.unjs.io/

We should also archive old repo

@yuyinws
Copy link
Contributor Author

yuyinws commented Mar 12, 2024

@sxzz Old repo's README has been update. But I have no access to archive it.

https://unplugin.vercel.app now redirect to the new one.

@sxzz
Copy link
Member

sxzz commented Mar 12, 2024

Now archived. Thanks for your amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants