Skip to content

Conversation

masatake
Copy link
Member

@masatake masatake commented May 14, 2025

Close #2628.

  • improve the test coverage

@masatake masatake force-pushed the prolog branch 3 times, most recently from 6a40e2e to c2cc60d Compare May 14, 2025 20:48
Copy link

codecov bot commented May 14, 2025

Codecov Report

❌ Patch coverage is 94.86486% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.98%. Comparing base (876e82a) to head (c99c2f4).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
parsers/prolog.c 96.81% 10 Missing ⚠️
main/tokeninfo.c 66.66% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4249      +/-   ##
==========================================
+ Coverage   85.92%   85.98%   +0.06%     
==========================================
  Files         248      249       +1     
  Lines       63733    64102     +369     
==========================================
+ Hits        54765    55121     +356     
- Misses       8968     8981      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masatake masatake force-pushed the prolog branch 4 times, most recently from da928d4 to 69adaf2 Compare May 18, 2025 09:11
@masatake masatake mentioned this pull request May 18, 2025
@masatake masatake marked this pull request as ready for review May 18, 2025 12:31
@masatake masatake added this to the 6.3 milestone May 20, 2025
@masatake masatake force-pushed the prolog branch 3 times, most recently from 9a60ebd to b928802 Compare June 2, 2025 16:36
@masatake masatake force-pushed the prolog branch 3 times, most recently from 6bbab30 to 81a473d Compare October 15, 2025 08:40
@masatake masatake requested a review from Copilot October 15, 2025 08:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new Prolog parser to Universal Ctags, implementing comprehensive tag extraction for predicates, grammars, and modules in Prolog source files. The parser supports various Prolog syntax features including module-qualified atoms, DCG rules, string literals, and numeric literals.

  • New Prolog parser with support for predicates, grammars, and modules
  • Language selection mechanism to differentiate between Perl and Prolog files
  • Integration with build system and test infrastructure

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
parsers/prolog.c Main parser implementation with tokenizer and tag extraction
main/tokeninfo.c Helper functions for token-based tag creation
main/tokeninfo.h Header declarations for new token utilities
main/selectors.c Language selection logic for Perl vs Prolog disambiguation
main/selectors.h Header for language selector function
parsers/perl.c Updated to use new language selector
main/parsers_p.h Registration of Prolog parser
source.mak Build system integration
win32/* Visual Studio project files
docs/news/HEAD.rst Documentation update
Units/parser-prolog.r/* Test cases and expected outputs
misc/validators/validator-swipl Validation script for SWI-Prolog
circle.yml CI configuration update
Tmain/* Updated test expectations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Close universal-ctags#2628.

Signed-off-by: Masatake YAMATO <[email protected]>
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@masatake masatake merged commit c71080d into universal-ctags:master Oct 15, 2025
82 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Prolog Parser

1 participant