Skip to content

Conversation

@zhexiao
Copy link

@zhexiao zhexiao commented Oct 9, 2019

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

❌ Patch coverage is 1.85185% with 53 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
document/run.go 0.00% 19 Missing ⚠️
document/document.go 5.26% 17 Missing and 1 partial ⚠️
document/oleobject.go 0.00% 16 Missing ⚠️

📢 Thoughts on this report? Let us know!

@gunnsth gunnsth requested a review from zgordan-vv October 10, 2019 14:17
@gunnsth gunnsth added the pending Awaiting feedback label Nov 18, 2019
@gunnsth
Copy link
Contributor

gunnsth commented Nov 18, 2019

@zhexiao Thanks very much for your contribution.

In summary, it looks to me that the PR involves:

  • Schema for: CT_ImageData, CT_OleObject, CT_Shape and support inside (CT_Object).
  • OleObjects() for Run
  • DrawingInline() for Run
  • document functions for working with OleObjectPath
  • Wmf file oleobject reading

Do you have any examples/testcases that demonstrate how this new functionality can be used?

@zhexiao
Copy link
Author

zhexiao commented Dec 20, 2019

@zhexiao Thanks very much for your contribution.

In summary, it looks to me that the PR involves:

  • Schema for: CT_ImageData, CT_OleObject, CT_Shape and support inside (CT_Object).
  • OleObjects() for Run
  • DrawingInline() for Run
  • document functions for working with OleObjectPath
  • Wmf file oleobject reading

Do you have any examples/testcases that demonstrate how this new functionality can be used?

Yes, You are right. My code is aimd to parse the Word OleObject .
Let me update the commit/comment info and create some tests.

@zhexiao zhexiao changed the title Get inline image from Document Run Schema for: CT_ImageData, CT_OleObject, CT_Shape and support inside (CT_Object). Dec 20, 2019
@zhexiao
Copy link
Author

zhexiao commented Dec 20, 2019

@zhexiao Thanks very much for your contribution.

In summary, it looks to me that the PR involves:

  • Schema for: CT_ImageData, CT_OleObject, CT_Shape and support inside (CT_Object).
  • OleObjects() for Run
  • DrawingInline() for Run
  • document functions for working with OleObjectPath
  • Wmf file oleobject reading

Do you have any examples/testcases that demonstrate how this new functionality can be used?

I just added an oleObject exmaple, please take a look.
example path: _examples/document/oleobject
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending Awaiting feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants