Skip to content

Conversation

@eggrobin
Copy link
Member

@eggrobin eggrobin commented Nov 13, 2025

Fix #454.

This is a pretty ugly parser, but at least it has fairly understandable error messages, e.g.:

  1. for DOTLESS BEH WITH DOT BELOW AND 3 DOTS ABOVE, given as an example in L2/11-092:
    Schematic name of U+0751: DOTLESS BEH with 1 dots BELOW should be plain BEH
    
  2. for BEH WITH 2 DOTS BELOW AND DOT ABOVE:
    Schematic name of U+0754: BEH with dots BELOW should be DOTLESS
    
  3. for the two iterations of wrong names in Four Arabic Pegon Characters #435:
    Schematic name of U+10EC2: Expected DAL based on Joining_Group DAL, got ARABIC LETTER DAL WITH TWO DOTS VERTICALLY BELOW
    Schematic name of U+10EC3: Expected TAH based on Joining_Group TAH, got ARABIC LETTER TAH WITH TWO DOTS VERTICALLY BELOW
    Schematic name of U+10EC4: Expected KAF based on Joining_Group KAF, got ARABIC LETTER KAF WITH TWO DOTS VERTICALLY BELOW
    
    and then
    Schematic name of U+10EC2: Expected pattern-unit, got TWO DOTS VERTICALLY BELOW
    Schematic name of U+10EC3: Expected pattern-unit, got TWO DOTS VERTICALLY BELOW
    Schematic name of U+10EC4: Expected pattern-unit, got TWO DOTS VERTICALLY BELOW
    
  4. for 10EE9; DOTLESS CROWN FEH WITH TWO DOTS ABOVE; L; CROWN FEH currently in the main branch:
    Schematic name of U+10EE9: Expected pattern-unit, got TWO DOTS ABOVE
    

@eggrobin eggrobin requested a review from roozbehp November 13, 2025 20:38
@eggrobin eggrobin requested a review from roozbehp November 18, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for ArabicShaping schematic name

2 participants