Skip to content

ICU-23280 Use uint64_t instead of int64_t to avoid overflow #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FrankYFTang merged 1 commit into from
Dec 9, 2025
Merged

ICU-23280 Use uint64_t instead of int64_t to avoid overflow #3789

FrankYFTang merged 1 commit into from
Dec 9, 2025
+15 −6

Conversation

@FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Dec 4, 2025 •
edited
Loading

Checklist

  • Required: Issue filed: ICU-23280
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

@FrankYFTang FrankYFTang requested a review from markusicu December 4, 2025 00:36
markusicu
markusicu reviewed Dec 4, 2025
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm tnx!

@markusicu markusicu self-assigned this Dec 4, 2025
@FrankYFTang FrankYFTang requested a review from markusicu December 4, 2025 18:28
@FrankYFTang FrankYFTang force-pushed the ICU-23280-tempCEFromIndexAndStrength branch from 7bf4f7e to 7b2166c Compare December 4, 2025 22:02
@jira-pull-request-webhook
Copy link

jira-pull-request-webhook bot commented Dec 4, 2025

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang merged commit 22ce6a4 into unicode-org:main Dec 9, 2025
97 checks passed
@FrankYFTang FrankYFTang deleted the ICU-23280-tempCEFromIndexAndStrength branch December 9, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markusicu markusicu markusicu approved these changes

Assignees

@markusicu markusicu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrankYFTang @markusicu