Skip to content

Conversation

@mihnita
Copy link
Contributor

@mihnita mihnita commented Dec 3, 2025

Checklist

  • Required: Issue filed: ICU-23270
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

@mihnita mihnita requested a review from echeran December 3, 2025 23:23
@mihnita
Copy link
Contributor Author

mihnita commented Dec 3, 2025

Not yet ready, I will add fixes and will do heavy testing.
But if you want a head-start, I don't plan to touch the existing commits anymore.
Only add on top of them, and (likely) squash all the "churn" added in to a final "Cleanup" commit

@mihnita
Copy link
Contributor Author

mihnita commented Dec 3, 2025

Still to do: CI, update doc, testing (lots of it!)

@markusicu markusicu marked this pull request as draft December 4, 2025 17:37
@mihnita mihnita force-pushed the mihai_mvn_refactor branch from adfab28 to 197201b Compare December 9, 2025 18:08
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4j/releases_tools/shared.sh is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita mihnita marked this pull request as ready for review December 9, 2025 19:16
@mihnita
Copy link
Contributor Author

mihnita commented Dec 9, 2025

Ready for review

@mihnita mihnita requested a review from echeran December 12, 2025 23:36
Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihnita
Copy link
Contributor Author

mihnita commented Dec 12, 2025

Thank you very much!

@mihnita
Copy link
Contributor Author

mihnita commented Dec 12, 2025

Do you want me to squash?

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita mihnita merged commit 87fb9d5 into unicode-org:mihai_mvn_refactor Dec 13, 2025
106 checks passed
@mihnita mihnita deleted the mihai_mvn_refactor branch December 13, 2025 18:21
@mihnita mihnita mentioned this pull request Dec 13, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants