Skip to content

ICU-23271 Fix a possible error about ambiguous overloads of U_ICU_NAMESPACE::internal::toU16StringView #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthew-wozniczka wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −4
Open

ICU-23271 Fix a possible error about ambiguous overloads of U_ICU_NAMESPACE::internal::toU16StringView #3786

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1911bf
[ICU-23271] Fix the error `include\unicode\unistr.h(2228,31): error C…
matthew-wozniczka Dec 3, 2025
4b279c8
[ICU-23271] Revert changes to `enable_if` conditions on `toU16StringV…
matthew-wozniczka Dec 3, 2025
9785383
[ICU-23271] Fix `couldn't deduce template parameter ‘T’` compile erro…
matthew-wozniczka Dec 3, 2025
feb41c7
[ICU-23271] Remove recently-added `DirectlyConvertibleToU16StringView…
matthew-wozniczka Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions icu4c/source/common/unicode/char16ptr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,10 +394,12 @@ constexpr bool ConvertibleToU16StringView =

namespace internal {
/**
* Pass-through overload.
* Pass-through overload for anything which is already implicitly convertible (including std::u16string_view itself).
* @internal
*/
inline std::u16string_view toU16StringView(std::u16string_view sv) { return sv; }
template <typename T,
typename = typename std::enable_if_t<std::is_convertible_v<T, std::u16string_view>>>
std::u16string_view toU16StringView(const T& text) { return text; }

#if !U_CHAR16_IS_TYPEDEF && (!defined(_LIBCPP_VERSION) || _LIBCPP_VERSION < 180000)
/**
Expand Down Expand Up @@ -427,7 +429,7 @@ inline std::u16string_view toU16StringView(std::wstring_view sv) {
*/
template <typename T,
typename = typename std::enable_if_t<!std::is_pointer_v<std::remove_reference_t<T>>>>
inline std::u16string_view toU16StringViewNullable(const T& text) {
std::u16string_view toU16StringViewNullable(const T& text) {
return toU16StringView(text);
}

Expand All @@ -438,7 +440,7 @@ inline std::u16string_view toU16StringViewNullable(const T& text) {
template <typename T,
typename = typename std::enable_if_t<std::is_pointer_v<std::remove_reference_t<T>>>,
typename = void>
inline std::u16string_view toU16StringViewNullable(const T& text) {
std::u16string_view toU16StringViewNullable(const T& text) {
if (text == nullptr) return {}; // For backward compatibility.
return toU16StringView(text);
}
Expand Down