CLDR-18671 quell noisy kbd test #5200
Merged
+25
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
commented
Nov 25, 2025
tools/cldr-code/src/main/java/org/unicode/cldr/util/DoctypeXmlStreamWrapper.java
Outdated
Show resolved
Hide resolved
srl295
commented
Nov 25, 2025
Comment on lines
-388
to
-389
| DoctypeXmlStreamWrapper.wrap(is); | ||
| xmlReader.parse(is); |
Member
Author
There was a problem hiding this comment.
error, the wrap() function had no side effect (it returns a wrapped object)
srl295
commented
Nov 25, 2025
| } | ||
| } | ||
|
|
||
| private static final Pattern numberAndType = PatternCache.get("^([0-9][0-9])\\/([a-zA-Z0-9]+)"); |
Member
Author
There was a problem hiding this comment.
we need to support any schema url including v45, etc. Ideally we would check conformsTo here, but at this level we don't typically have access to cldr-archive.
- support any version of the xmlns prefix, not just the latest
- support any version of the xmlns prefix, not just the latest - use the wrapper in more places
srl295
force-pushed
the
cldr-18671/noisy-kbd-test
branch
from
7b4ac5d to
354a2f6
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
pedberg-icu
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18671
There's more to do, but remove a lot of noise in the keyboard tests, by fixing the DTD Wrapper
ALLOW_MANY_COMMITS=true