CLDR-18518 abstracts: work around CORS, improve logging on ui #4615
+145
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix the error message on deferHelp (dbPedia extract) - add logError, logException, logInfo, logWarning to cldrNotify for low level datadog logging without showing a message popup (these will go to datadog) - cleanup some noise in initial gui load and ajax load (Browser debugger panel for network shows better information here anyway) - workaround CORS issue with dbpedia by adding the hostname of the request to the query, this way the cache is individual for, say, smoketest vs. production (vs local) - otherwise they aren't shareable.
- example, az-short https://st.unicode.org/cldr-apps/v#/ab/Languages_A_D/700f7be0e77ae39b had no abstract but az did
btangmu
previously approved these changes
Apr 16, 2025
- add comment to clarify CORS issue - restructure per code review - use fetch() instead of jQuery
btangmu
previously approved these changes
Apr 16, 2025
| const url = new URL(endpoint); | ||
| url.searchParams.append("query", query); | ||
| url.searchParams.append("format", "JSON"); | ||
| return fetch(url); |
There was a problem hiding this comment.
I like to use cldrAjax.doFetch but I guess it's not appropriate for a non-unicode.org server. We might consider a new cldrAjax function for other servers. It's good to go thru a single module for http.
There was a problem hiding this comment.
That would leak the session key! I would be fine with a generic fetch, it could even just be re-exported fetch() would that work
btangmu
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18518
This PR completes the ticket.
ALLOW_MANY_COMMITS=true