Skip to content

CLDR-18520 Update Kosovo subdivisions in en.xml #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

drilaexe
Copy link

@drilaexe drilaexe commented Apr 16, 2025

Update Kosovo subdivisions in en.xml to reflect latest administrative divisions

CLDR-18520

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

Update Kosovo subdivisions in en.xml to reflect latest administrative divisions
@drilaexe drilaexe changed the title Update en.xml CLDR-18520 Update en.xml Apr 16, 2025
@conradarcturus
Copy link
Contributor

Generally LGTM, however... Since Kosovo (XK) is not universally recognized, we may want to leave the Serbian Kosovo regions in place. I’m not certain what the precedent is. I'm tagging other people to review this change.

@conradarcturus
Copy link
Contributor

A better name for this PR would be "Update Kosovo subdivisions in en.xml"

@drilaexe drilaexe changed the title CLDR-18520 Update en.xml CLDR-18520 Update Kosovo subdivisions in en.xml Apr 16, 2025
@drilaexe
Copy link
Author

Thank you for the feedback. I’ve retained the old subdivisions as they were, while also updating the name as requested. I understand the complexity regarding the recognition of Kosovo, and I’ve ensured that the previous data is still present.

I’ve also updated the PR title to "Update Kosovo subdivisions in en.xml" for clarity.

@conradarcturus
Copy link
Contributor

Looks good to me but I want someone else from CLDR to accept since they have more experience with changes like this.

Copy link
Member

@btangmu btangmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tests are failing:

   TestAttributeValues {
    TestValid
Warning:  (TestAttributeValues.java:301)  Warning: Invalid	/home/runner/work/cldr/cldr/common/subdivisions/en.xml	subdivision	type	xk01
...
  TestPaths {
    TestNonLdml
Error:  (TestPaths.java:630)  Error: subdivisions/en.xml/subdivision@type, expected match to: ⟪or/validity/subdivision||literal/AS, AW, AX, BL, CP, CW, GF, GP, GU, HK, IC, MF, MO, MP, MQ, NC, PF, PM, PR, RE, SX, TA, TF, TW, UM, VI, WF, YT, itsd, no50⟫ actual: «xk01»

and similarly for xk02, ... .

I'm not familiar with that code. From a quick look it I suspect both tests expect to find these values enumerated in the DTD as allowable values and it's not finding them there.

<subdivision type="rs27">Prizren</subdivision> <!-- in rskm : Kosovo-Metohija -->
<subdivision type="rs28">Kosovska Mitrovica</subdivision> <!-- in rskm : Kosovo-Metohija -->
<subdivision type="rs29">Kosovo-Pomoravlje</subdivision> <!-- in rskm : Kosovo-Metohija -->
<subdivision type="rskm">Kosovo-Metohija</subdivision>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a space has been inserted before the first tab in each of these lines, otherwise there's no change in these lines

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally revert that

@srl295
Copy link
Member

srl295 commented Apr 21, 2025

Two tests are failing:

   TestAttributeValues {
    TestValid
Warning:  (TestAttributeValues.java:301)  Warning: Invalid	/home/runner/work/cldr/cldr/common/subdivisions/en.xml	subdivision	type	xk01
...
  TestPaths {
    TestNonLdml
Error:  (TestPaths.java:630)  Error: subdivisions/en.xml/subdivision@type, expected match to: ⟪or/validity/subdivision||literal/AS, AW, AX, BL, CP, CW, GF, GP, GU, HK, IC, MF, MO, MP, MQ, NC, PF, PM, PR, RE, SX, TA, TF, TW, UM, VI, WF, YT, itsd, no50⟫ actual: «xk01»

and similarly for xk02, ... .

I'm not familiar with that code. From a quick look it I suspect both tests expect to find these values enumerated in the DTD as allowable values and it's not finding them there.

  • the validity data is off in validity/subdivisions.xml
  • which is generated by GenerateValidityXml
  • which is based on the containment data in common/supplemental/subdivisions.xml
  • which is generated from GenerateSubdivisions SubDivisionExtractor
  • which is based on ISO data I don't have

the ISO data set won't contain Kosovar subdivisions I assume.

Probably needs more discussion.

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants