CLDR-18999 Allow the build script to push changes into the repo #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
consistent-octopus
branch
from
2a1201d to
26c07f0
Compare
srl295
reviewed
Dec 5, 2025
| git config --global user.name "GitHub Actions" | ||
| git config --global user.email "[email protected]" | ||
| git add cldr-json | ||
| git commit --verbose -F - < (echo "Automated update; echo; cat ../cldr-identity.txt") |
Member
There was a problem hiding this comment.
this line isn't quite right, too many levels of quotes. it will result in a commit message Automated update; echo; cat..
I think the first line could give a little more details as well.
Probably instead something like
( echo ... ) | git commit ... -F -
srl295
requested changes
Dec 5, 2025
Member
srl295
left a comment
srl295
left a comment
There was a problem hiding this comment.
this should NOT be run nightly. There's no reason to make nightly changes to the repo here.
Perhaps instead it could draft a PR or update a branch.
icu4x needs the .zip file, so a nightly run that generates a .zip might be OK (as a build artifact)
srl295
reviewed
Dec 5, 2025
|
|
||
| # override the version number of CLDR | ||
| #VERSION="39.0.0" | ||
| VERSION="49.0.0-dev" |
Member
There was a problem hiding this comment.
please revert this. it's calculated.
Member
There was a problem hiding this comment.
Suggested change
| VERSION="49.0.0-dev" | |
| #VERSION="39.0.0" |
srl295
reviewed
Dec 5, 2025
| echo "VERSION is undefined, exiting from $0" | ||
| exit 1 | ||
| fi | ||
| VERSION="$(jq -r .version cldr-json/cldr-core/package.json)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behind a flag.
This could run nightly.