Skip to content

Conversation

@behinger
Copy link
Member

@behinger behinger commented Oct 27, 2025

  • removed duplicated function
  • make link checker happy
  • make linter happy
  • generalized the test
  • added packages to top
  • added precompilation
  • type stable designmatrix generation

Related issues

Closes #

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

@behinger behinger added the run benchmark runs the benchmark CI label Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.57%. Comparing base (0a5ccdb) to head (0fcd9b8).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/condense.jl 88.23% 2 Missing ⚠️
src/designmatrix.jl 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   63.33%   63.57%   +0.24%     
==========================================
  Files          23       23              
  Lines        1361     1370       +9     
==========================================
+ Hits          862      871       +9     
  Misses        499      499              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Benchmark Results

main 0fcd9b8... main / 0fcd9b8...
designmat/lin 0.192 ± 0.019 ms 0.181 ± 0.017 ms 1.06 ± 0.15
designmat/lmm 0.0885 ± 0.011 s 0.089 ± 0.0092 s 0.994 ± 0.16
effects/lin 1.06 ± 0.14 ms 0.783 ± 0.047 ms 1.35 ± 0.19
effects/lin_spl 27.2 ± 1.1 ms 24.6 ± 0.82 ms 1.11 ± 0.058
fit/lin 0.3 ± 0.053 ms 0.296 ± 0.023 ms 1.02 ± 0.2
fit/lin_deconv 1.54 ± 0.042 ms 1.52 ± 0.04 ms 1.01 ± 0.038
fit/lmm 0.07 ± 0.0016 s 0.0705 ± 0.00049 s 0.994 ± 0.024
time_to_load 3.37 ± 0.019 s 3.44 ± 0.045 s 0.98 ± 0.014

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@behinger behinger merged commit ec45fd1 into main Dec 11, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run benchmark runs the benchmark CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants