Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new fields to api (WIP) #54

Merged
merged 2 commits into from
May 2, 2023
Merged

Conversation

sergiomarrocoli
Copy link
Contributor

@sergiomarrocoli sergiomarrocoli commented Apr 20, 2023

Add additional fields to API. Will need linked tickets to be merged and deployed first

  # WDPA_PID    - wdpa_parent_id
  # GIS_M_AREA  - gis_marine_area
  # GIS_AREA    - gis_area
  # INT_CRIT    - international_criteria (changed during import)
  # VERIF       - verif
  # PARENT_ISO3 - parent_iso3
  # MARINE      - marine_type

  # Already present
  # PA_DEF      >    :is_oecm field
  # DESIG_ENG   > designation, includes child record of jurisdiction, e.g. National
  # METADATAID  > becomes sources (changed during import and converted to sources association)

@sergiomarrocoli sergiomarrocoli force-pushed the feat/188/add-fields-to-api branch from e9fb8f3 to 5438c8d Compare April 20, 2023 10:03
@stacytalbot
Copy link
Contributor

This one feels like an error DESIG_ENG > governance_type (changed during import)
If governance_type is mapped to DESIG_ENG what is mapped to GOV_TYPE?

@stacytalbot
Copy link
Contributor

WDPA_PID - wdpa_parent_id the P stands for parcel, not parent.

@sergiomarrocoli sergiomarrocoli force-pushed the feat/188/add-fields-to-api branch from 4454b7e to b378dba Compare April 30, 2023 22:10
@sergiomarrocoli
Copy link
Contributor Author

governance_type: you're right, that's a mistake. it's already returned as :designation (not :governance_type)

wdpa_parent_id: it's been wdpa_parent_id in PP for 7 years. i've aliased it in the API under a method, to return as wdpa_pid

@sergiomarrocoli sergiomarrocoli marked this pull request as ready for review April 30, 2023 22:15
@sergiomarrocoli sergiomarrocoli force-pushed the feat/188/add-fields-to-api branch 2 times, most recently from 774170f to 951dca2 Compare May 2, 2023 09:21
@sergiomarrocoli sergiomarrocoli force-pushed the feat/188/add-fields-to-api branch from 951dca2 to 932a38f Compare May 2, 2023 09:22
@stacytalbot
Copy link
Contributor

Confirmed that DESIG is still missing. I am going to leave it like this for now but I have made a note of it.
Merging.

@stacytalbot stacytalbot merged commit 0317ed9 into develop May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants