feat(protected_areas): added attributes in database to the API. Fixed broken attributes #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is working well and the code looks good. Just a reminder to run the rake task on staging/prod once deployed to make the changes visible in the response. Happy for this to be merged! |
lucacug
approved these changes
Mar 21, 2022
sergiomarrocoli
added a commit
that referenced
this pull request
Mar 21, 2022
feat(protected_areas): added attributes in database to the API. Fixed broken attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some extra fields to the API response, updates the documentation, and fixes some non-working attributes.
To test:
set up this app, making sure db is pointed at your protected planet database
run
rake api_users:reset_permissionsmake API calls to /v3/protected_areas and /v3/protected_areas/:id
api response should include :green_list_status, :is_oecm, :supplementary_info, :conservation_objectives, :green_list_url, :green_list_status, and :sub_locations should display correctly