-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: consistent with sdk behavior #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe Changes
Assessment against linked issues
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
deploy/docker/config.yml (1)
24-31
: Duplicatessl_*
keys – prune for clarityThe Redis section repeats the four
ssl_*
fields, making maintenance error-prone:24 ssl_cert_reqs: None 25 ssl_ca_certs: None 26 ssl_certfile: None 27 ssl_keyfile: None 28 ssl_cert_reqs: None # duplicate 29 ssl_ca_certs: None # duplicate 30 ssl_certfile: None # duplicate 31 ssl_keyfile: None # duplicateRecommend removing the second block:
- ssl_cert_reqs: None - ssl_ca_certs: None - ssl_certfile: None - ssl_keyfile: NoneThis keeps the config terse and avoids confusion about which value “wins”.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
deploy/docker/config.yml
(2 hunks)
🔇 Additional comments (1)
deploy/docker/config.yml (1)
55-55
: Behavioral toggle:simulate_user
flipped tofalse
– verify downstream impactTurning off user-simulation changes how the crawler presents itself (e.g. UA strings, input events).
Please double-check:
- Any tests or integration environments that implicitly relied on
simulate_user: true
.- Runtime code that branches on this value and may now skip human-like delays or fingerprint-evasion steps.
- Docs / README snippets that still advertise user-simulation as enabled by default.
If everything is aligned with the SDK and no regressions are expected, feel free to mark this resolved.
Close #1262
Summary by CodeRabbit