Skip to content

feat: consistent with sdk behavior #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vvanglro
Copy link

@vvanglro vvanglro commented Jul 1, 2025

Close #1262

Summary by CodeRabbit

  • Chores
    • Updated crawler configuration to disable user simulation.

Copy link
Contributor

coderabbitai bot commented Jul 1, 2025

Walkthrough

The simulate_user parameter in the crawler's Docker configuration file was changed from true to false, aligning it with the SDK settings. No other functional or structural modifications were made, aside from the addition of a trailing newline at the end of the file.

Changes

File(s) Change Summary
deploy/docker/config.yml Changed simulate_user from true to false; added trailing newline.

Assessment against linked issues

Objective Addressed Explanation
Keep the SDK and Docker API parameters consistent, specifically simulate_user (#1262)

Poem

In the warren of configs, a flag set anew,
simulate_user now false, to keep things true.
SDK and Docker, now hand in paw,
Bringing harmony, without a flaw.
A hop, a skip, a bug now gone—
The rabbit approves, and hops along! 🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
deploy/docker/config.yml (1)

24-31: Duplicate ssl_* keys – prune for clarity

The Redis section repeats the four ssl_* fields, making maintenance error-prone:

24  ssl_cert_reqs: None
25  ssl_ca_certs: None
26  ssl_certfile: None
27  ssl_keyfile: None
28  ssl_cert_reqs: None   # duplicate
29  ssl_ca_certs: None    # duplicate
30  ssl_certfile: None    # duplicate
31  ssl_keyfile: None     # duplicate

Recommend removing the second block:

-  ssl_cert_reqs: None
-  ssl_ca_certs: None
-  ssl_certfile: None
-  ssl_keyfile: None

This keeps the config terse and avoids confusion about which value “wins”.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02f3127 and b4bc845.

📒 Files selected for processing (1)
  • deploy/docker/config.yml (2 hunks)
🔇 Additional comments (1)
deploy/docker/config.yml (1)

55-55: Behavioral toggle: simulate_user flipped to false – verify downstream impact

Turning off user-simulation changes how the crawler presents itself (e.g. UA strings, input events).
Please double-check:

  1. Any tests or integration environments that implicitly relied on simulate_user: true.
  2. Runtime code that branches on this value and may now skip human-like delays or fingerprint-evasion steps.
  3. Docs / README snippets that still advertise user-simulation as enabled by default.

If everything is aligned with the SDK and no regressions are expected, feel free to mark this resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Please keep the SDK and Docker API parameters consistent.
1 participant