Repository navigation
Conversation
paskal
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2216
I changed the image stamp to hash tracked files on disk instead of combining HEAD tree hashes, a diff and porcelain status. Staging or committing an existing edit now leaves the stamp unchanged. I skip deleted tracked files so staging and committing a removal behave the same way, and keep the existing name-only detection for untracked files and the separate coverage stamp.
I added a standalone shell regression test and wired it into the e2e workflow's cheap gate. It covers edits, staging, commits, deletions, paths with spaces, untracked names, suite-only commits, the Telegram stub and coverage mode. I also ran it against the original stamp script: it fails on the staging assertion there and passes with this change.
Validation I ran locally:
sh e2e/stamp_test.sh— all 16 assertions passed, including a rerun on the committed change.shellcheck e2e/stamp.sh e2e/stamp_test.sh,sh -n e2e/stamp.sh e2e/stamp_test.shandgit diff origin/master...HEAD --check.cd backend/app && go test -timeout=300s -count 1 ./....cd backend/_example/memory_store && go test -race ./... && go build -race ./....cd backend && golangci-lint runandcd backend/_example/memory_store && golangci-lint run --config ../../.golangci.ymlusing v2.13.2 built with Go 1.27.0.cd e2e && go vet -tags=e2e ./...andgolangci-lint run --build-tags=e2e --config ../backend/.golangci.ymlwith the same toolchain.I could not run the full Docker build and browser suite locally because this environment cannot access the Docker socket. I am leaving those checks to the existing e2e CI workflow; the shell regression does not require Docker or browsers.