Skip to content

Conversation

@99mini
Copy link
Member

@99mini 99mini commented May 31, 2025

#️⃣연관된 이슈

📝작업 내용

  • package.json을 참고하여 exports 에 선언된 방식으로 import 하여 사용할 수 있습니다.
- `@ummgoban/shared`
- `@ummgoban/shared/react`
- `@ummgoban/shared/types`
- `@ummgoban/shared/utils`
- `@ummgoban/shared/http`
- `@ummgoban/shared/http/error`
- `@ummgoban/shared/http/api-client`

CI

  • workflows/check.yml에서 Lint, Format, Type Check, Test, Build 테스트 진행

배포방법

  • main은 신뢰가능한 최신 코드를 유지합니다.
  • tag를 push 함으로써 실제 배포를 수행합니다.

추가 고려 사항

  • packages는 tag push를 통해서 관리하고 있지만 relesae는 자동화되지 않아서 추후 해보고 싶을 때 작업할게요.
  • 하고싶으신 분이 해보서도 좋습니다.

스크린샷 (선택)

💬리뷰 요구사항(선택)

@99mini 99mini requested a review from l-lyun May 31, 2025 12:01
@99mini 99mini self-assigned this May 31, 2025
@99mini 99mini requested a review from itslitulinchpin2 May 31, 2025 12:04
@99mini 99mini changed the title feat: api client 와 각종 공통 타입 선언합니다. feat: api client, React와 각종 공통 타입 선언합니다. May 31, 2025
@99mini 99mini requested a review from Copilot May 31, 2025 13:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes shared resources by adding an HTTP API client, common types, utilities, and React hooks for the ummgoban project.

  • Implement ApiClient with axios interceptors for auth and error handling
  • Add hash utility with tests and document its collision warning
  • Introduce shared TypeScript type definitions and reorganize package exports, build config, and CI pipelines

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/ummgoban-http/api-client/api-client.ts Axios-based API client implementation
src/lib/uitls/hash/hash.ts Add 6-digit hash utility with JSDoc comments
src/lib/uitls/hash/hash.spec.ts Add tests for hash utility
src/lib/types/*.type.ts New shared TypeScript type definitions
src/lib/types/index.ts Export reorganized type modules
src/index.ts Update package exports for HTTP and React packages
rollup.config.mjs Add path alias and exclude test files in build
package.json Update exports, scripts, and dependencies
.github/workflows/*.yml Extend CI workflows to include build step
README.md Document new exports and publish process
Comments suppressed due to low confidence (1)

src/lib/uitls/hash/hash.ts:1

  • The directory uitls is misspelled; it should be utils to match the naming used elsewhere.
src/lib/uitls/hash/hash.ts

@99mini 99mini merged commit 90b7ef8 into main Jun 1, 2025
1 check passed
@99mini 99mini deleted the feature/api-method branch June 1, 2025 02:14
@l-lyun
Copy link

l-lyun commented Jun 1, 2025

확인했습니다!! 다음주에 더 살펴볼게요 기술 도입 감사합니다 👍

@99mini
Copy link
Member Author

99mini commented Jun 1, 2025

axios client를 하고 싶었는데 RN 문제인지 해당 패키지에서 가져오는 코드를 못쓰네요...일단 react, types는 사용됩니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants