-
Notifications
You must be signed in to change notification settings - Fork 0
feat: api client, React와 각종 공통 타입 선언합니다. #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR centralizes shared resources by adding an HTTP API client, common types, utilities, and React hooks for the ummgoban project.
- Implement
ApiClientwith axios interceptors for auth and error handling - Add hash utility with tests and document its collision warning
- Introduce shared TypeScript type definitions and reorganize package exports, build config, and CI pipelines
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ummgoban-http/api-client/api-client.ts | Axios-based API client implementation |
| src/lib/uitls/hash/hash.ts | Add 6-digit hash utility with JSDoc comments |
| src/lib/uitls/hash/hash.spec.ts | Add tests for hash utility |
| src/lib/types/*.type.ts | New shared TypeScript type definitions |
| src/lib/types/index.ts | Export reorganized type modules |
| src/index.ts | Update package exports for HTTP and React packages |
| rollup.config.mjs | Add path alias and exclude test files in build |
| package.json | Update exports, scripts, and dependencies |
| .github/workflows/*.yml | Extend CI workflows to include build step |
| README.md | Document new exports and publish process |
Comments suppressed due to low confidence (1)
src/lib/uitls/hash/hash.ts:1
- The directory
uitlsis misspelled; it should beutilsto match the naming used elsewhere.
src/lib/uitls/hash/hash.ts
|
확인했습니다!! 다음주에 더 살펴볼게요 기술 도입 감사합니다 👍 |
|
axios client를 하고 싶었는데 RN 문제인지 해당 패키지에서 가져오는 코드를 못쓰네요...일단 react, types는 사용됩니다 |
#️⃣연관된 이슈
📝작업 내용
CI
workflows/check.yml에서 Lint, Format, Type Check, Test, Build 테스트 진행배포방법
tag를 push 함으로써 실제 배포를 수행합니다.추가 고려 사항
packages는 tag push를 통해서 관리하고 있지만 relesae는 자동화되지 않아서 추후 해보고 싶을 때 작업할게요.스크린샷 (선택)
💬리뷰 요구사항(선택)