-
Notifications
You must be signed in to change notification settings - Fork 0
feat: webview setting #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces WebView functionality to replace native market detail screens with web-based views for improved development efficiency. The changes implement a configurable WebView component with proper navigation handling and hardware back button support.
- WebView component implementation with navigation state management
- Navigation routing abstraction to centralize market detail navigation
- HOC pattern for WebView integration across all navigators
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/webview/WebViewScreen.tsx | New WebView component with back navigation and external link handling |
| src/navigation/withWebViewGate.tsx | HOC to conditionally render WebView based on route parameters |
| src/navigation/navigator.ts | Centralized routing function for market detail navigation |
| src/navigation/index.tsx | Integration of WebView gate with all navigators |
| src/types/StackNavigationType.ts | Type definitions for WebView parameters |
| Multiple screen files | Refactored to use centralized routing function |
| package.json | Added react-native-webview dependency |
l-lyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
세팅 감사합니다 ~! 👍
#️⃣연관된 이슈
📝작업 내용
작업해야되는 사항
스크린샷 (선택)
💬리뷰 요구사항(선택)