Skip to content

Conversation

@99mini
Copy link
Member

@99mini 99mini commented Aug 9, 2025

#️⃣연관된 이슈

📝작업 내용

  • 상품 주문 플로우 (가게 상세 확인 -> 장바구니 담기 -> 결제화면)를 웹뷰로 전환하는게 개발하기 더 빠를것같다는 생각이 들었습니다..
  • 추후 생산성 고려했을때 이게 더 좋겠죠?
  • https://github.com/ummgoban/web-view 레포지토리도 만들었습니다.
  • 우선 개발환경에서 사용할 수 있게 설정만해두었습니다.
  • Detail -> MarketDetail 라우팅 시 웹뷰를 띄울 수 있게 하였습니다.
  • 상품 주문 플로우 전체를 수정하면 너무 많은 공수가 들수 있으니 상세페이지만 우선 교체할 수 있으면 좋을 것 같아요

작업해야되는 사항

  • http header 주입
  • 웹<->앱 브릿지
  • 웹과 앱의 디자인 컴포넌트 통일성
  • 웹뷰 도메인 설정

스크린샷 (선택)

💬리뷰 요구사항(선택)

@99mini 99mini self-assigned this Aug 9, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces WebView functionality to replace native market detail screens with web-based views for improved development efficiency. The changes implement a configurable WebView component with proper navigation handling and hardware back button support.

  • WebView component implementation with navigation state management
  • Navigation routing abstraction to centralize market detail navigation
  • HOC pattern for WebView integration across all navigators

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/webview/WebViewScreen.tsx New WebView component with back navigation and external link handling
src/navigation/withWebViewGate.tsx HOC to conditionally render WebView based on route parameters
src/navigation/navigator.ts Centralized routing function for market detail navigation
src/navigation/index.tsx Integration of WebView gate with all navigators
src/types/StackNavigationType.ts Type definitions for WebView parameters
Multiple screen files Refactored to use centralized routing function
package.json Added react-native-webview dependency

Copy link
Contributor

@l-lyun l-lyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세팅 감사합니다 ~! 👍

@99mini 99mini merged commit 2840c54 into main Aug 16, 2025
1 check passed
@99mini 99mini deleted the feature/web-view branch August 16, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants