-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 요일별 휴업 기능 적용 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: 요일별 휴업 기능 적용 #131
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
510d353
deps: ummgoban/shared v0.0.5 version up
l-lyun 9db1ddb
fix: 요일 관련 타입 shared 패키지로 대치
l-lyun dd5c734
feat: 휴업 체크박스 생성 및 영업 시간 테이블화
l-lyun ce86f4d
comment: share 타입 fixme 작성
l-lyun 82703d2
feat: 공통 컴포넌트 체크박스 제작
l-lyun 5ceebc6
fix: 제작한 체크박스로 대치
l-lyun 4ef8f8a
fix: lint error
l-lyun 272411c
ci: yarn install --immutable 추가하여 의존성 고정
l-lyun 9964847
ci: immutable 키워드 삭제
l-lyun c663aa9
chore: github action script
l-lyun 4da014f
deps: shared package version change
l-lyun 11aaaf9
chore: yarn.lock change
l-lyun 2b03585
chore: 미사용 파일 삭제
l-lyun a079d7c
comment: 주석 수정
l-lyun 3d2bb04
chore: customcheckbox -> squarecheckbox 컴포넌트명 변경
l-lyun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import styled from '@emotion/native'; | ||
|
|
||
| const S = { | ||
| Container: styled.View` | ||
| display: flex; | ||
| background-color: ${({theme}) => theme.colors.secondary}; | ||
|
|
||
| border-radius: 8px; | ||
| justify-content: center; | ||
| align-items: center; | ||
| width: 32px; | ||
| height: 32px; | ||
| `, | ||
|
|
||
| TouchWrapper: styled.Pressable` | ||
| justify-content: center; | ||
| align-items: center; | ||
| width: 100%; | ||
| height: 100%; | ||
| `, | ||
| }; | ||
|
|
||
| export default S; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import React from 'react'; | ||
| import Icon from 'react-native-vector-icons/Entypo'; | ||
| import S from './CustomCheckbox.style'; | ||
|
|
||
| type CustomCheckboxProps = { | ||
| checked: boolean; | ||
| onPress: () => void; | ||
| size?: number; | ||
| color?: string; | ||
| }; | ||
|
|
||
| const CustomCheckbox = ({ | ||
| checked, | ||
| onPress, | ||
| size = 18, | ||
| color = 'black', | ||
| }: CustomCheckboxProps) => { | ||
| return ( | ||
| <S.Container> | ||
| <S.TouchWrapper onPress={onPress}> | ||
| {checked && <Icon name="check" size={size} color={color} />} | ||
| </S.TouchWrapper> | ||
| </S.Container> | ||
| ); | ||
| }; | ||
|
|
||
| export default CustomCheckbox; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export {default as CustomCheckbox} from './CustomCheckbox'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그냥 Checkbox 라는 이름으로 사용해도 될 것같아요
아니면 사각형이니까
SquareCheckbox로 작명하고 추후 변경사항이 생기면CircleCheckbox,...등등 추가하고 한 단계 추상화 컴포넌트를 만드는 것으로 확장하죠Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 좋습니다~! SquareCheckbox로 진행하겠습니다 👍