Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support browsersList #797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
"@types/minimatch": "3.0.5",
"@types/node": "^18.15.13",
"@umijs/test": "^4.0.68",
"browserslist": "^4.24.3",
"git-repo-info": "^2.1.1",
"husky": "^8.0.3",
"jest": "^27",
Expand Down
46 changes: 43 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

75 changes: 44 additions & 31 deletions src/builder/bundle/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { webpack } from '@umijs/bundler-webpack';
import { chalk, importLazy, lodash } from '@umijs/utils';
import browsersList from 'browserslist';
import path from 'path';
import { getCachePath, logger } from '../../utils';
import type { BundleConfigProvider } from '../config';
Expand Down Expand Up @@ -57,39 +58,53 @@ async function bundle(opts: IBundleOpts): Promise<void | IBundleWatcher> {
{ leading: true, trailing: false },
);

const buildConfig: any = {
alias: config.alias,
autoprefixer: config.autoprefixer,
chainWebpack: config.chainWebpack,
define: config.define,
devtool: config.sourcemap && 'source-map',
externals: config.externals,
outputPath: config.output.path,

// postcss config
extraPostCSSPlugins,
postcssLoader,

...(config.extractCSS !== false ? {} : { styleLoader: {} }),

// less config
theme: config.theme,

// compatible with IE11 by default
// targets: getBundleTargets(config),
jsMinifier: JSMinifier.terser,
cssMinifier: CSSMinifier.cssnano,
extraBabelIncludes: [/node_modules/],

// set cache parent directory, will join it with `bundler-webpack`
// ref: https://github.com/umijs/umi/blob/8dad8c5af0197cd62db11f4b4c85d6bc1db57db1/packages/bundler-webpack/src/build.ts#L32
cacheDirectoryPath: getCachePath(),
};

let presetEnv: any = {};
const browsersListConfig = browsersList.loadConfig({
path: process.cwd(),
});
if (browsersListConfig) {
presetEnv.ignoreBrowserslistConfig = false;
presetEnv.useBuiltIns = 'entry';
} else {
const targets = getBundleTargets(config);
presetEnv.targets = targets;
buildConfig.targets = targets;
}
// log for normal build
!opts.watch && logStatus();
await bundler.build({
cwd: opts.cwd,
watch: opts.watch,
config: {
alias: config.alias,
autoprefixer: config.autoprefixer,
chainWebpack: config.chainWebpack,
define: config.define,
devtool: config.sourcemap && 'source-map',
externals: config.externals,
outputPath: config.output.path,

// postcss config
extraPostCSSPlugins,
postcssLoader,

...(config.extractCSS !== false ? {} : { styleLoader: {} }),

// less config
theme: config.theme,

// compatible with IE11 by default
targets: getBundleTargets(config),
jsMinifier: JSMinifier.terser,
cssMinifier: CSSMinifier.cssnano,
extraBabelIncludes: [/node_modules/],

// set cache parent directory, will join it with `bundler-webpack`
// ref: https://github.com/umijs/umi/blob/8dad8c5af0197cd62db11f4b4c85d6bc1db57db1/packages/bundler-webpack/src/build.ts#L32
cacheDirectoryPath: getCachePath(),
},
config: buildConfig,
entry: {
[path.parse(config.output.filename).name]: path.join(
opts.cwd,
Expand All @@ -99,9 +114,7 @@ async function bundle(opts: IBundleOpts): Promise<void | IBundleWatcher> {
babelPreset: [
require.resolve('@umijs/babel-preset-umi'),
{
presetEnv: {
targets: getBundleTargets(config),
},
presetEnv,
presetReact: getBabelPresetReactOpts(
opts.configProvider.pkg,
opts.cwd,
Expand Down
16 changes: 12 additions & 4 deletions src/builder/bundless/loaders/javascript/babel.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { transform } from '@umijs/bundler-utils/compiled/babel/core';
import { winPath } from '@umijs/utils';
import browsersList from 'browserslist';
import path from 'path';
import { IFatherBundlessTypes } from '../../../../types';
import {
Expand Down Expand Up @@ -28,6 +29,16 @@ function getParsedDefine(define: Record<string, string>) {
* babel transformer
*/
const babelTransformer: IJSTransformerFn = function (content) {
let presetEnv: any = {
modules: this.config.format === IFatherBundlessTypes.ESM ? false : 'auto',
};
const browsersListConfig = browsersList.loadConfig({ path: this.paths.cwd });
if (browsersListConfig) {
presetEnv.ignoreBrowserslistConfig = false;
} else {
presetEnv.targets = getBundlessTargets(this.config);
}

const {
extraBabelPlugins = [],
extraBabelPresets = [],
Expand All @@ -36,10 +47,7 @@ const babelTransformer: IJSTransformerFn = function (content) {
} = this.config;
// TODO: correct optional in umi types and replace any here
const presetOpts: any = {
presetEnv: {
targets: getBundlessTargets(this.config),
modules: this.config.format === IFatherBundlessTypes.ESM ? false : 'auto',
},
presetEnv,
presetReact: getBabelPresetReactOpts(
this.pkg,
path.dirname(this.paths.fileAbsPath),
Expand Down
Loading