Skip to content

Commit

Permalink
Merge branch 'transport-redesign' into implement-autonat-v2
Browse files Browse the repository at this point in the history
  • Loading branch information
umgefahren authored Apr 30, 2024
2 parents e640920 + 0d5dcba commit 480337e
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 30 deletions.
31 changes: 12 additions & 19 deletions swarm/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -597,9 +597,7 @@ where
}

Check failure on line 597 in swarm/src/lib.rs

View workflow job for this annotation

GitHub Actions / rustfmt

Diff in /home/runner/work/rust-libp2p/rust-libp2p/swarm/src/lib.rs

self.behaviour
.on_swarm_event(FromSwarm::NewListener(behaviour::NewListener {
listener_id,
}));
.on_swarm_event(FromSwarm::NewListener(behaviour::NewListener { listener_id }));

Ok(())
}
Expand All @@ -610,9 +608,7 @@ where
/// The address is broadcast to all [`NetworkBehaviour`]s via [`FromSwarm::ExternalAddrConfirmed`].

Check failure on line 608 in swarm/src/lib.rs

View workflow job for this annotation

GitHub Actions / rustfmt

Diff in /home/runner/work/rust-libp2p/rust-libp2p/swarm/src/lib.rs
pub fn add_external_address(&mut self, a: Multiaddr) {
self.behaviour
.on_swarm_event(FromSwarm::ExternalAddrConfirmed(ExternalAddrConfirmed {
addr: &a,
}));
.on_swarm_event(FromSwarm::ExternalAddrConfirmed(ExternalAddrConfirmed { addr: &a }));
self.confirmed_external_addr.insert(a);
}

Expand Down Expand Up @@ -1059,9 +1055,9 @@ where
);

Check failure on line 1055 in swarm/src/lib.rs

View workflow job for this annotation

GitHub Actions / rustfmt

Diff in /home/runner/work/rust-libp2p/rust-libp2p/swarm/src/lib.rs
let addrs = self.listened_addrs.remove(&listener_id).unwrap_or_default();
for addr in addrs.iter() {
self.behaviour.on_swarm_event(FromSwarm::ExpiredListenAddr(
ExpiredListenAddr { listener_id, addr },
));
self.behaviour.on_swarm_event(
FromSwarm::ExpiredListenAddr(ExpiredListenAddr { listener_id, addr })
);
}
self.behaviour
.on_swarm_event(FromSwarm::ListenerClosed(ListenerClosed {
Expand Down Expand Up @@ -2155,9 +2151,9 @@ mod tests {
{}

Check failure on line 2151 in swarm/src/lib.rs

View workflow job for this annotation

GitHub Actions / rustfmt

Diff in /home/runner/work/rust-libp2p/rust-libp2p/swarm/src/lib.rs

match swarm2.poll_next_unpin(cx) {
Poll::Ready(Some(SwarmEvent::OutgoingConnectionError {
peer_id, error, ..
})) => Poll::Ready((peer_id, error)),
Poll::Ready(Some(SwarmEvent::OutgoingConnectionError { peer_id, error, .. })) => {
Poll::Ready((peer_id, error))
}
Poll::Ready(x) => panic!("unexpected {x:?}"),
Poll::Pending => Poll::Pending,
}
Expand Down Expand Up @@ -2223,9 +2219,7 @@ mod tests {
return Poll::Ready(Ok(()));

Check failure on line 2219 in swarm/src/lib.rs

View workflow job for this annotation

GitHub Actions / rustfmt

Diff in /home/runner/work/rust-libp2p/rust-libp2p/swarm/src/lib.rs
}
}
Poll::Ready(Some(SwarmEvent::IncomingConnectionError {
local_addr, ..
})) => {
Poll::Ready(Some(SwarmEvent::IncomingConnectionError { local_addr, .. })) => {
assert!(!got_inc_err);
assert_eq!(local_addr, local_address);
got_inc_err = true;
Expand Down Expand Up @@ -2346,10 +2340,9 @@ mod tests {
// This constitutes a fairly typical error for chained transports.

Check failure on line 2340 in swarm/src/lib.rs

View workflow job for this annotation

GitHub Actions / rustfmt

Diff in /home/runner/work/rust-libp2p/rust-libp2p/swarm/src/lib.rs
let error = DialError::Transport(vec![(
"/ip4/127.0.0.1/tcp/80".parse().unwrap(),
TransportError::Other(io::Error::new(
io::ErrorKind::Other,
MemoryTransportError::Unreachable,
)),
TransportError::Other(
io::Error::new(io::ErrorKind::Other, MemoryTransportError::Unreachable)
),
)]);

let string = format!("{error}");
Expand Down
23 changes: 12 additions & 11 deletions transports/tcp/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -802,9 +802,7 @@ mod tests {
.unwrap()

Check failure on line 802 in transports/tcp/src/lib.rs

View workflow job for this annotation

GitHub Actions / rustfmt

Diff in /home/runner/work/rust-libp2p/rust-libp2p/transports/tcp/src/lib.rs
),
Ok(SocketAddr::new(
IpAddr::V6(Ipv6Addr::new(
65535, 65535, 65535, 65535, 65535, 65535, 65535, 65535,
)),
IpAddr::V6(Ipv6Addr::new(65535, 65535, 65535, 65535, 65535, 65535, 65535, 65535,)),
8080,
))
);
Expand Down Expand Up @@ -1092,6 +1090,7 @@ mod tests {

#[test]
fn port_reuse_listening() {
env_logger::try_init().ok();
let _ = tracing_subscriber::fmt()
.with_env_filter(tracing_subscriber::EnvFilter::from_default_env())
.try_init();
Expand Down Expand Up @@ -1276,10 +1275,11 @@ mod tests {

Check failure on line 1275 in transports/tcp/src/lib.rs

View workflow job for this annotation

GitHub Actions / rustfmt

Diff in /home/runner/work/rust-libp2p/rust-libp2p/transports/tcp/src/lib.rs
#[cfg(feature = "tokio")]
{
let rt = ::tokio::runtime::Builder::new_current_thread()
.enable_io()
.build()
.unwrap();
let rt =
::tokio::runtime::Builder::new_current_thread()
.enable_io()
.build()
.unwrap();
assert!(rt.block_on(cycle_listeners::<tokio::Tcp>()));
}
}
Expand Down Expand Up @@ -1312,10 +1312,11 @@ mod tests {
}

Check failure on line 1312 in transports/tcp/src/lib.rs

View workflow job for this annotation

GitHub Actions / rustfmt

Diff in /home/runner/work/rust-libp2p/rust-libp2p/transports/tcp/src/lib.rs
#[cfg(feature = "tokio")]
{
let rt = ::tokio::runtime::Builder::new_current_thread()
.enable_io()
.build()
.unwrap();
let rt =
::tokio::runtime::Builder::new_current_thread()
.enable_io()
.build()
.unwrap();
rt.block_on(async {
test::<tokio::Tcp>();
});
Expand Down

0 comments on commit 480337e

Please sign in to comment.