- 
                Notifications
    
You must be signed in to change notification settings  - Fork 28
 
Non root user #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Non root user #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bitcurious,
Thank you for taking the initiative to add instructions on how to run the wrapper with non-root user privileges. However, since this solution depends on a modified version of the Payload-SDK code, we cannot merge it into this repository.
Here is what I propose:
- Please add these instructions to your forked repository.
 - I will include a reference in our repository, directing users to your instructions or other community-supported solutions.
 - In parallel, we can open an issue in the official Payload-SDK repository to request support for this feature in future releases.
 
Thanks again for your contribution and I hope you understand why this cannot be merged.
| GIT_REPOSITORY https://github.com/bitcurious/Payload-SDK.git | ||
| GIT_TAG non-root-user | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bitcurious we cannot fetch a Payload-SDK repository which is not the main one from DJI. This will complicate a lot things whenever we would like to upgrade the Payload-SDK versions to the latest ones. I think we can add instructions on how users could run the code with non-root settings, but that is as much as we can do as this depends on the official DJI codebase. Another way would be to open an issue to the Payload-SDK from DJI and request these changes.
I hope you understand the reasons why we cannot add this here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. I will updated it in my forked repository.
Basic Info
Description of contribution in a few bullet points
Motivation and Context
How Has This Been Tested?
Description of documentation updates required from your changes
Update the PSDK ROS 2 Wiki to include instructions that anyone wanting to run the PSDK wrapper as a non-root user should use the non_root_user branch.
I have also updated the README file with instructions on how to set up the sudoers file, making it easily accessible for everyone. Please let me know if this needs to be added to the PSDK wrapper Wiki as well.
Future work that may be required in bullet points
Screenshots (if appropriate):