Skip to content

Conversation

@bitcurious
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #107
Primary OS tested on Ubuntu
Drone platform tested on M300 RTK

Description of contribution in a few bullet points

  • Modified the PSDK repository to allow it to run without requiring root privileges.

Motivation and Context

  • Many users of the PSDK wrapper have expressed the need to run it as a non-root user for easier integration with their applications. Noticing this demand, I made the necessary changes and updates to accommodate running the PSDK wrapper without root privileges.

How Has This Been Tested?

  • Tested on a Linux-based operating system with the M300 drone, but it is applicable to any drone.

Description of documentation updates required from your changes

  • Update the PSDK ROS 2 Wiki to include instructions that anyone wanting to run the PSDK wrapper as a non-root user should use the non_root_user branch.

  • I have also updated the README file with instructions on how to set up the sudoers file, making it easily accessible for everyone. Please let me know if this needs to be added to the PSDK wrapper Wiki as well.


Future work that may be required in bullet points

  • Ensure that any future merge requests are also integrated into the non_root_user branch.

Screenshots (if appropriate):

@bitcurious bitcurious requested a review from a team as a code owner September 4, 2024 11:31
Copy link
Contributor

@biancabnd biancabnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bitcurious,
Thank you for taking the initiative to add instructions on how to run the wrapper with non-root user privileges. However, since this solution depends on a modified version of the Payload-SDK code, we cannot merge it into this repository.

Here is what I propose:

  • Please add these instructions to your forked repository.
  • I will include a reference in our repository, directing users to your instructions or other community-supported solutions.
  • In parallel, we can open an issue in the official Payload-SDK repository to request support for this feature in future releases.

Thanks again for your contribution and I hope you understand why this cannot be merged.

Comment on lines +42 to +43
GIT_REPOSITORY https://github.com/bitcurious/Payload-SDK.git
GIT_TAG non-root-user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitcurious we cannot fetch a Payload-SDK repository which is not the main one from DJI. This will complicate a lot things whenever we would like to upgrade the Payload-SDK versions to the latest ones. I think we can add instructions on how users could run the code with non-root settings, but that is as much as we can do as this depends on the official DJI codebase. Another way would be to open an issue to the Payload-SDK from DJI and request these changes.

I hope you understand the reasons why we cannot add this here.

Copy link
Contributor Author

@bitcurious bitcurious Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. I will updated it in my forked repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants