-
-
Notifications
You must be signed in to change notification settings - Fork 79
Implement basic reloading #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'll have a look at this |
|
@VAWVAW ah nvm, just gotta get past the initial sign-on |
|
cargo install --locked iambFound the correct compiling instructions Followed these instructions from the docs (slightly modified): $ gh repo clone VAWVAW/iamb.git hot-reload
$ cd hot-reload
$ git checkout -b hot-reload
$ cargo build --release
$ ./target/release/iamb --version
iamb 0.0.10 (2e6376f) |
|
You still haven't got the right branch. The version should be
I can run the branch using: |
|
I got it and from what I can see, the notifications don't seem to be resetting Are there ways to send you logs or some sort of debug for this? |
|
No, there are no relevant logs. This PR currently only replaces the in-memory representation of the config. But there are a lot of other places in the code where the settings might be copied or applied. I need a list of all config options that don't just work and need some extra code to handle. Some of them might be too complex to implement. |
|
ah okay I'll make another profile and do some more testing so far I don't see notification settings updating |
This adds
:reloadto reload some config options.Options not currently affected:
log_levelFurther testing is needed to see which options need to be handled in code.
fixes #505