Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format.yml #2311

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Update format.yml #2311

merged 1 commit into from
Jan 6, 2025

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 1, 2025

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced GitHub Actions workflow for improved token handling in auto-formatting jobs. πŸ”§

πŸ“Š Key Changes

  • Updated the token parameter in the formatting workflow to support fallback with secrets.GITHUB_TOKEN.

🎯 Purpose & Impact

  • Purpose: Ensures the workflow operates even if the _GITHUB_TOKEN secret is not available by using the default GITHUB_TOKEN as a fallback.
  • Impact: Increases reliability of automated formatting tasks, reducing potential errors in CI workflows. βœ…

Signed-off-by: Glenn Jocher <[email protected]>
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Jan 1, 2025
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/yolov3 πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolov3 main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics CI checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement (CLA) if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. Remember, "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. This is an automated response, but an Ultralytics engineer will assist you soon. Thank you for contributing to Ultralytics! πŸš€

@glenn-jocher glenn-jocher merged commit 39b54d3 into master Jan 6, 2025
9 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch January 6, 2025 19:46
@UltralyticsAssistant
Copy link
Member

πŸŽ‰ Exciting newsβ€”your PR has been merged, @glenn-jocher! πŸš€

Your thoughtful enhancement to our Actions workflow ensures stronger, more reliable automation, and that’s a huge win for the team. πŸ”§βœ…

As Marcus Aurelius once said, "What stands in the way becomes the way." Your proactive fix turns potential roadblocks into stepping stones for seamless CI processes. Thank you for your dedication and for making an impact that will ripple through our workflows. πŸ™Œ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants